From 18c28481f91dfe499f563e360d8c18ee79993b8f Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Wed, 11 Mar 2026 10:50:59 -0700 Subject: [PATCH 1/6] Make a small edit --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index deb84f908b7..6d18fa68cf7 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -20,7 +20,7 @@ follow our [beta testing guidance](https://github.com/flutter/devtools/blob/mast We gladly accept contributions via GitHub pull requests! We encourage you to read the [Welcome](https://github.com/flutter/flutter/blob/master/CONTRIBUTING.md#welcome) remarks in the Flutter framework's contributing guide, as all of that information applies to contributing to the `flutter/devtools` -repo as well. +repo as well. Small edit We communicate primarily over GitHub and [Discord](https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md) on the [#hackers-devtools](https://discord.com/channels/608014603317936148/1106667330093723668) channel. From f76f627c89b051cd76683c9fa04cb0728d416223 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Wed, 11 Mar 2026 11:27:04 -0700 Subject: [PATCH 2/6] Update contribution guidelines and PR request template --- .github/PULL_REQUEST_TEMPLATE.md | 40 +++++++++++++++++++++++++++----- CONTRIBUTING.md | 4 +++- 2 files changed, 37 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 803e341dd48..de982a39068 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,19 +1,45 @@ -*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* - *List which issues are fixed by this PR.* -*Please add a note to `packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md` if your change requires release notes. Otherwise, add the 'release-notes-not-required' label to the PR.* +*Replace this paragraph with a description of what this PR is changing or adding, and why. If your PR is updating any UI functionality, please include include before/after screenshots and/or a gif of the UI interaction.* ## Pre-launch Checklist +### General checklist + - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read the [Flutter Style Guide] _recently_, and have followed its advice. - [ ] I signed the [CLA]. -- [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). -- [ ] I added new tests to check the change I am making, or there is a reason for not adding tests. +### Issues checklist + +- [ ] I listed at least one issue that this PR fixes in the description above. +- [ ] I listed at least one issue which has the [`soliciting-contributions`] label. +- [ ] I did not list at least one issue with the [`soliciting-contributions`] label. I understand this means my PR might take longer to be reviewed. + +### Tests checklist + +- [ ] I added new tests to check the change I am making... +- [ ] OR there is a reason for not adding tests. + +### AI-tooling checklist + +- [ ] I did not use any AI tooling in creating this PR. +- [ ] OR I did use AI tooling, and... + * [ ] I read the [AI contributions guidelines] + * [ ] I reviewed all AI-generated code before opening this PR. + * [ ] I understand and am able to discuss the code in this PR. + * [ ] I have verifed the accuracy of any AI-generated text included in the PR description. + +### Feature-change checklist + +- [ ] This PR does not change the DevTools UI or behavior and... + * [ ] I added the `release-notes-not-required` label or left a comment requesting the label be added. +- [ ] OR this PR does change the DevTools UI or behavior and... + * [ ] I added an entry to `packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md`. + * [ ] I included before/after screenshots and/or a GIF demo of the new UI to my PR description. + * [ ] I ran the DevTools app locally to manually verify my changes. ![build.yaml badge] @@ -24,5 +50,7 @@ If you need help, consider asking for help on [Discord]. [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [Flutter Style Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md [CLA]: https://cla.developers.google.com/ -[Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md +[`soliciting-contributions`]: https://github.com/flutter/devtools/issues?q=state%3Aopen%20label%3Asoliciting-contributions +[AI contributions guideline]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [build.yaml badge]: https://github.com/flutter/devtools/actions/workflows/build.yaml/badge.svg +[Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6d18fa68cf7..31801a3c6c1 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -20,11 +20,13 @@ follow our [beta testing guidance](https://github.com/flutter/devtools/blob/mast We gladly accept contributions via GitHub pull requests! We encourage you to read the [Welcome](https://github.com/flutter/flutter/blob/master/CONTRIBUTING.md#welcome) remarks in the Flutter framework's contributing guide, as all of that information applies to contributing to the `flutter/devtools` -repo as well. Small edit +repo as well. We communicate primarily over GitHub and [Discord](https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md) on the [#hackers-devtools](https://discord.com/channels/608014603317936148/1106667330093723668) channel. +We prioritize reviewing PRs for issues with the [`soliciting-contributions`](https://github.com/flutter/devtools/issues?q=state%3Aopen%20label%3Asoliciting-contributions) label. If you are looking for an issue to fix, please check that label first. + Before contributing code: 1. Complete the From 03f68ec02f6fd4e491ea17e55999ae1c85c7f0a9 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Wed, 11 Mar 2026 14:51:55 -0700 Subject: [PATCH 3/6] Refer to contributions-welcome and good-first-issue --- .github/PULL_REQUEST_TEMPLATE.md | 7 ++++--- CONTRIBUTING.md | 6 ++++-- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index de982a39068..30add22bee8 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -15,8 +15,8 @@ ### Issues checklist - [ ] I listed at least one issue that this PR fixes in the description above. -- [ ] I listed at least one issue which has the [`soliciting-contributions`] label. -- [ ] I did not list at least one issue with the [`soliciting-contributions`] label. I understand this means my PR might take longer to be reviewed. +- [ ] I listed at least one issue which has the [`contributions-welcome`] or [`good-first-issue`] label. +- [ ] I did not list at least one issue with the [`contributions-welcome`] or [`good-first-issue`] label. I understand this means my PR might take longer to be reviewed. ### Tests checklist @@ -50,7 +50,8 @@ If you need help, consider asking for help on [Discord]. [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [Flutter Style Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md [CLA]: https://cla.developers.google.com/ -[`soliciting-contributions`]: https://github.com/flutter/devtools/issues?q=state%3Aopen%20label%3Asoliciting-contributions +[`contributions-welcome`]: https://github.com/flutter/devtools/issues?q=state%3Aopen%20label%3Acontributions-welcome +[`good-first-issue`]: https://github.com/flutter/devtools/issues?q=state%3Aopen%20label%3Agood-first-issue [AI contributions guideline]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [build.yaml badge]: https://github.com/flutter/devtools/actions/workflows/build.yaml/badge.svg [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 31801a3c6c1..86ffc9f1714 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -22,11 +22,13 @@ We gladly accept contributions via GitHub pull requests! We encourage you to rea framework's contributing guide, as all of that information applies to contributing to the `flutter/devtools` repo as well. +We prioritize reviewing PRs that address issues with the following labels: +* [`good-first-issue`](https://github.com/flutter/devtools/issues?q=state%3Aopen%20label%3Agood-first-issue): Small and easy issues that can be tackled by a first-time contributor. +* [`contributions-welcome`](https://github.com/flutter/devtools/issues?q=state%3Aopen%20label%3Acontributions-welcome): Issues of any size or difficulty that we consider high-priority fixes. + We communicate primarily over GitHub and [Discord](https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md) on the [#hackers-devtools](https://discord.com/channels/608014603317936148/1106667330093723668) channel. -We prioritize reviewing PRs for issues with the [`soliciting-contributions`](https://github.com/flutter/devtools/issues?q=state%3Aopen%20label%3Asoliciting-contributions) label. If you are looking for an issue to fix, please check that label first. - Before contributing code: 1. Complete the From bdd127afe07806400e1b4f8bc98c3ce418afe093 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Wed, 11 Mar 2026 14:54:12 -0700 Subject: [PATCH 4/6] Update test checklist --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 30add22bee8..e7b91972427 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -21,7 +21,7 @@ ### Tests checklist - [ ] I added new tests to check the change I am making... -- [ ] OR there is a reason for not adding tests. +- [ ] OR there is a reason for not adding tests. If this is the case, please explain why in the PR description. ### AI-tooling checklist From ca8121317c56bf86397bbeb4ee0c17eb8905736a Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Wed, 11 Mar 2026 14:55:34 -0700 Subject: [PATCH 5/6] Update test phrasing --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e7b91972427..b9a0ce61cd0 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -21,7 +21,7 @@ ### Tests checklist - [ ] I added new tests to check the change I am making... -- [ ] OR there is a reason for not adding tests. If this is the case, please explain why in the PR description. +- [ ] OR there is a reason for not adding tests, which I explained in the PR description. ### AI-tooling checklist From 8dd9fa32522dff0693229481288e9a115f4e5382 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Thu, 12 Mar 2026 09:56:20 -0700 Subject: [PATCH 6/6] Update AI checklist --- .github/PULL_REQUEST_TEMPLATE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b9a0ce61cd0..82b89ec4570 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -27,10 +27,11 @@ - [ ] I did not use any AI tooling in creating this PR. - [ ] OR I did use AI tooling, and... - * [ ] I read the [AI contributions guidelines] + * [ ] I read the [AI contributions guidelines] and agree to follow them. * [ ] I reviewed all AI-generated code before opening this PR. * [ ] I understand and am able to discuss the code in this PR. * [ ] I have verifed the accuracy of any AI-generated text included in the PR description. + * [ ] I commit to verifying the accuracy of any AI-generated code or text that I upload in response to review comments. ### Feature-change checklist