From f87f7b02e4ca0348e7db202a0bb889068b2e0228 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Tue, 14 Apr 2026 16:21:15 -0700 Subject: [PATCH 1/2] Update TRIAGE and CONTRIBUTING docs --- CONTRIBUTING.md | 6 ++++++ TRIAGE.md | 10 ++++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 86ffc9f1714..2bfec4f3ea7 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -154,6 +154,12 @@ not want to merge `upstream/master` or update your Flutter SDK version, instead If the version of DCM used on the bots is outdated, consider contributing a PR to update the version on the bots to the latest. +## Companion app + +For most DevTools features, we recommend using the [DevTools companion +app](https://github.com/flutter/demos/tree/main/devexp_demos/devtools_companion) +as the example Flutter app to connect to when working on DevTools. + ## Running and debugging DevTools Please see [DEBUGGING.md]() for guidance on running and debugging DevTools. diff --git a/TRIAGE.md b/TRIAGE.md index 331ff6a1d87..3ff74d54dc5 100644 --- a/TRIAGE.md +++ b/TRIAGE.md @@ -27,7 +27,7 @@ by applying [proper labels](#label-the-issue) and [assigning priority](#prioriti Transfer any issues to the `flutter/devtools` repo that should be tracked on our own issue tracker, and close issues you find that are obsolete. 4. Try to reproduce any issues with the [reproduce to verify](https://github.com/flutter/devtools/labels/reproduce%20to%20verify) label. -5. Spend at least 20 minutes [cleaning up the issue backlog](#clean-up-the-issue-backlog). +5. Spend at least 20 minutes [cleaning up the issue backlog](#clean-up-the-issue-backlog) and/or labeling backlog issues with "contributions welcome" or "good first issue". 6. Look through the DevTools discord [channel](https://discord.com/channels/608014603317936148/958862085297672282) for any recent user questions or concerns that require a response. @@ -36,9 +36,11 @@ questions or concerns that require a response. * Add labels for its proper category or categories ( “screen: inspector", “screen: network", “bug”, etc.) * Add cost labels ("cost: low", "cost: medium", etc.) if you have a good idea of how much work it will take to resolve this issue. Leave the cost label off if you do not know. -* Add label “waiting for customer response” if you requested more details from reporter -* Add label “fix it friday” if the issue should be fixed and looks easy to fix -* Add label "good first issue" if the issue looks like an easy starter bug for a new contributor +* Add label "waiting for customer response" if you requested more details from reporter. +* Add label "contributions welcome" for issues that can be tackled by the community.* +* Add label "good first issue" if the issue looks like an easy starter bug for a new contributor.* + +> [*] In our contribution guidelines we suggest that contributors use the "contributions welcome" and "good first issue" labels to find issues to work on. Therefore, it is important to keep these lists well-populated. ### Prioritize the issue From 78f69a754a3e635d1a550b3862b2d3cbd99a49c3 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Thu, 16 Apr 2026 09:14:06 -0700 Subject: [PATCH 2/2] Fix DCM lints --- .../lib/src/shared/console/eval/auto_complete.dart | 6 ++---- .../devtools_shared/lib/src/extensions/extension_model.dart | 1 - 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/devtools_app/lib/src/shared/console/eval/auto_complete.dart b/packages/devtools_app/lib/src/shared/console/eval/auto_complete.dart index 5cfc2aa3ab7..f0277067c3a 100644 --- a/packages/devtools_app/lib/src/shared/console/eval/auto_complete.dart +++ b/packages/devtools_app/lib/src/shared/console/eval/auto_complete.dart @@ -94,9 +94,7 @@ Future> autoCompleteResultsFor( } } catch (_) {} } - return result.nonNulls - .where((name) => name.startsWith(parts.activeWord)) - .toList(); + return result.where((name) => name.startsWith(parts.activeWord)).toList(); } // Due to https://github.com/dart-lang/sdk/issues/46221 @@ -197,7 +195,7 @@ Future> _libraryMemberAutocompletes( final members = functions.map( (funcRef) => funcRef.name!.replaceAll('=', ''), ); - result.addAll(members.nonNulls); + result.addAll(members); } final classes = library.classes; if (classes != null) { diff --git a/packages/devtools_shared/lib/src/extensions/extension_model.dart b/packages/devtools_shared/lib/src/extensions/extension_model.dart index 39d480638cd..e1630dec524 100644 --- a/packages/devtools_shared/lib/src/extensions/extension_model.dart +++ b/packages/devtools_shared/lib/src/extensions/extension_model.dart @@ -39,7 +39,6 @@ class DevToolsExtensionConfig implements Comparable { nameKey: final String name, issueTrackerKey: final String issueTracker, versionKey: final String version, - // ignore: avoid-unnecessary-type-assertions, this can be a String or an int materialIconCodePointKey: final Object codePointFromJson, // The expected keys below are not from the extension's config.yaml // file; they are generated during the extension detection mechanism