feat: add support for using CDP auth token directly#177
Merged
Conversation
reblem
changed the title
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (58.33%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
============================================
+ Coverage 80.51% 80.86% +0.35%
- Complexity 1703 1728 +25
============================================
Files 122 123 +1
Lines 4941 5011 +70
Branches 520 528 +8
============================================
+ Hits 3978 4052 +74
+ Misses 735 727 -8
- Partials 228 232 +4
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
KaviarasuSakthivadivel
requested changes
Apr 30, 2026
KaviarasuSakthivadivel
force-pushed
the
rlemma/support-cdp-auth
branch
from
ae4e585 to
d8e1fac
Compare
KaviarasuSakthivadivel
force-pushed
the
rlemma/support-cdp-auth
branch
from
38f91b6 to
f6a93ac
Compare
KaviarasuSakthivadivel
approved these changes
May 18, 2026
mkaufmann
approved these changes
May 20, 2026
…asource Both the OAuth and direct CDP-token flows built identical auth interceptor, gRPC channel, stub provider, and DataCloudConnection wiring. Merge them into a single createConnection that takes the already-constructed collaborators (TokenProcessorSupplier, host, userName, lakehouse supplier, dataspaces supplier).
- TokenProcessorSupplierTest: exercises all three constructors (DataCloudTokenProvider, DirectCdpTokenProcessor, raw supplier) asserting getToken / getAudience delegate correctly. - DataCloudJDBCDriverTest: end-to-end DriverManager.getConnection via the cdpToken/tenantUrl branch, plus a negative case for an invalid JWT.
- DirectCdpTokenProcessorTest: add cases for the rebuild branch (cache cleared, cached-but-expired) and the wrap-on-rebuild-failure path. DirectCdpTokenProcessor is now at 100% line/branch coverage. - TokenProcessorSupplierTest: add cases asserting SneakyThrows propagates supplier SQLExceptions through getToken / getAudience.
- Validate tenantUrl is a bare hostname (reject scheme/port/path/whitespace) so users get a clear error instead of an opaque gRPC connect failure - Drive cached-token TTL from the JWT exp claim instead of a fixed 3600s default, with safe fallback when the JWT can't be parsed - Drop the brittle reflection-based test that forced an unreachable rebuild failure; replace with focused secondsUntilJwtExpiry unit tests - Collapse the duplicate TokenProcessorSupplier delegation test that re-exercised JWT parsing already covered in DirectCdpTokenProcessorTest - Generate JWTs dynamically in tests so exp stays in the future
KaviarasuSakthivadivel
force-pushed
the
rlemma/support-cdp-auth
branch
from
f6a93ac to
cdd24e1
Compare
…thods - Drop FALLBACK_EXPIRES_IN_SECONDS; expFromJwt() throws SQLException when the JWT is malformed or has no numeric exp claim. Bearer JWTs are required to carry exp; soft-falling-back to 1h was hiding bugs. - buildDataCloudToken() throws SQLException if the supplied JWT is already expired, surfacing at ofDestructive instead of producing a dead-on-arrival token the server later rejects with an opaque 401. - Fold the standalone validateToken() into buildDataCloudToken(): the tenant-id assertion lives next to the rest of construction. - Rename getLakehouse() → getLakehouseName() to match the OAuth-path sibling DataCloudTokenProvider.getLakehouseName(), and update the caller in DataCloudDatasource.
KaviarasuSakthivadivel
approved these changes
May 20, 2026
mkaufmann
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for using a CDP auth token directly instead of requiring a Core Salesforce token that must be exchanged for a CDP token. The CDP access token is accepted as a Bearer token via new
cdpTokenandtenantUrlconnection properties, and validates the JWT eagerly.