Bootstrap repo setup#2
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c263accc5d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| python -m venv .venv | ||
| . .venv/bin/activate | ||
| python -m pip install --upgrade pip | ||
| python -m pip install -e ".[dev]" pre-commit |
There was a problem hiding this comment.
The post-create script now runs python -m pip install -e ".[dev]" pre-commit, but this commit removes the repository’s Python project metadata (pyproject.toml), so editable install of . fails (Directory '.' is not installable) during devcontainer bootstrap. In a fresh Codespace/devcontainer, this aborts setup before pre-commit install and before Codex config initialization, so contributors cannot complete environment provisioning.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Please double-check the code reviewer's recommendation. If the gap or concern they pointed out is valid, think hard about possible ways to resolve the problem/address their feedback. List the options. Then, develop an evaluation rubric to score the options and determine which is best. Apply the evaluation rubric to the options and display the results/scores in a table. Then, use the table to select the best option. Finally, implement the necessary changes corresponding to the selected option.
…tions - Updated `.github/instructions/yaml.instructions.md` to specify absolute URLs for internal links. - Modified agent files (`AGENTS.md`, `CLAUDE.md`, `GEMINI.md`) to streamline validation commands and remove references to Python and Terraform. - Deprecated `phase-0-bootstrap-codex-instructions.md` and updated its related metadata for historical context. - Revised `phase-0-bootstrap-pr-description.md` to reflect changes in protected instruction cleanup and authorization.
1 participant
This pull request makes several improvements to project configuration, development environment setup, and repository metadata. The most significant changes include customizing the bug report issue template for this project, updating code ownership assignments, making the devcontainer setup more robust and cross-platform, and enforcing consistent line endings for shell scripts.
Repository metadata and workflow:
.github/ISSUE_TEMPLATE/bug_report.ymlto remove template comments, clarify instructions, add project-specific fields (such as provider and environment details), and streamline the bug reporting process for this repository..github/CODEOWNERSto assign ownership to@franklesniakinstead of a placeholder, ensuring correct code review routing.Development environment and tooling:
.devcontainer/post-create.shto fix issues withsudo npmdropping the Node feature's bin directory fromPATH, ensure global npm installs work reliably, and reclaim ownership of the.codexdirectory if it was previously created as root..devcontainer/devcontainer-lock.jsonto lock down versions of devcontainer features (common-utils, git-lfs, node, powershell, python), improving reproducibility of the development environment.Cross-platform consistency:
.gitattributesto enforce LF line endings for all.shfiles, preventing issues when scripts are checked out on Windows and run in Linux containers.