From e995f5f5f32fefa0b3daa4d766496d31968468e2 Mon Sep 17 00:00:00 2001 From: hjoncour Date: Tue, 17 Mar 2026 22:42:57 -0400 Subject: [PATCH] fix(bug): hiding icons --- .gitignore | 1 + package-lock.json | 4 ++-- package.json | 2 +- src/adapters/github/index.ts | 10 +++++----- src/adapters/github/selectors.ts | 1 - ssmver.toml | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.gitignore b/.gitignore index aaff377..b496a3c 100644 --- a/.gitignore +++ b/.gitignore @@ -153,3 +153,4 @@ tmp .docs .DS_Store .ssmver/ +GitHub Icons/ diff --git a/package-lock.json b/package-lock.json index 4a042c2..7ffd5bf 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "chrome-github-icons", - "version": "0.5.1", + "version": "0.5.2", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "chrome-github-icons", - "version": "0.5.1", + "version": "0.5.2", "hasInstallScript": true, "dependencies": { "@iconify-json/vscode-icons": "^1.2.45", diff --git a/package.json b/package.json index c618206..acfc988 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "chrome-github-icons", "description": "Cross-browser extension that replaces GitHub file icons with Material Design icons.", "private": true, - "version": "0.5.1", + "version": "0.5.2", "type": "module", "scripts": { "sync:assets": "tsx scripts/copy-icons.ts", diff --git a/src/adapters/github/index.ts b/src/adapters/github/index.ts index ec40d43..b0618b1 100644 --- a/src/adapters/github/index.ts +++ b/src/adapters/github/index.ts @@ -72,6 +72,11 @@ export class GitHubAdapter implements SiteAdapter { originalIcon.style.display = 'none'; + if (existingReplacement) { + existingReplacement.src = iconUrl; + return; + } + // Clean up any orphaned replacement images in the same parent // (happens when GitHub swaps SVGs for open/closed folder states) const parent = originalIcon.parentElement; @@ -81,11 +86,6 @@ export class GitHubAdapter implements SiteAdapter { .forEach((orphan) => orphan.remove()); } - if (existingReplacement) { - existingReplacement.src = iconUrl; - return; - } - const replacement = this.createReplacementImage(originalIcon, iconUrl); originalIcon.insertAdjacentElement('afterend', replacement); } diff --git a/src/adapters/github/selectors.ts b/src/adapters/github/selectors.ts index cb8e00a..6b86c88 100644 --- a/src/adapters/github/selectors.ts +++ b/src/adapters/github/selectors.ts @@ -33,7 +33,6 @@ const GITHUB_ENTRY_CONTAINER_SELECTOR = [ '[role="treeitem"]', '[data-testid="tree-view-item"]', '.PRIVATE_TreeView-item-container', - '.PRIVATE_TreeView-item-content', 'tr.js-navigation-item', 'li.js-navigation-item', 'div[role="row"]', diff --git a/ssmver.toml b/ssmver.toml index cb9e98a..1150b45 100644 --- a/ssmver.toml +++ b/ssmver.toml @@ -1,4 +1,4 @@ -version = "0.5.1" +version = "0.5.2" [settings] mode = "branch"