Typo in project search paths

[philpem]

This one tripped me up when I tried to build Disk Image Manager from source. There's a typo in the project search paths:

DiscImageManager/LazarusSource/DiscImageManager.lpi

Line 38 in 53d4758

<OtherUnitFiles Value="../SpriteToBitmap;../GJHCustomConponents"/>

The path included for GJHCustomComponents is "GJHCustomConponents" -- note the N in place of an M.

[geraldholdsworth]

I have noticed that too – it tripped me up. Seems I created the directory on my Mac and never noticed the mis-spelling until I manually entered the directory name in another project and it kept failing. So, as I now have many projects with this same typo, I just left it as is. From: Phil ***@***.***> Reply to: geraldholdsworth/DiscImageManager ***@***.***> Date: Sunday, 21 December 2025 at 17:30 To: geraldholdsworth/DiscImageManager ***@***.***> Cc: Subscribed ***@***.***> Subject: [geraldholdsworth/DiscImageManager] Typo in project search paths (Issue #38) philpem created an issue (geraldholdsworth/DiscImageManager#38) This one tripped me up when I tried to build Disk Image Manager from source. There's a typo in the project search paths: https://github.com/geraldholdsworth/DiscImageManager/blob/53d4758e335bbbf6fb9655d4f41140699685672f/LazarusSource/DiscImageManager.lpi#L38 The path included for GJHCustomComponents is "GJHCustomConponents" -- note the N in place of an M. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[philpem]

Okay, I'll make a note to symlink it but it would be good if this was mentioned in the README.

In my automated build script for the Docker container, I've added both - so it shouldn't be affected if this is ever fixed.

[philpem]

I was just talking to a friend about this, and he pointed out there's a really easy and backwards-compatible fix:

Have both search paths (with the M, and with the M -> N typo) on the search path in the project file.

This won't affect my build environment as both links will go to the same place -- though I guess the non-typo'ed path should be first.

[philpem]

I just realised you could also solve the "need to do two checkouts" thing with Git submodules, which means a git clone --recursive command would pull down everything needed to build Disc Image Manager:

git clone https://github.com/geraldholdsworth/DiscImageManager
cd DiscImageManager
git submodule add https://github.com/geraldholdsworth/SpriteToBitmap ExternalLibraries/SpriteToBitmap
git submodule add https://github.com/geraldholdsworth/GJHCustomComponents ExternalLibraries/GJHCustomComponents
ln -s "ExternalLibraries/SpriteToBitmap/Lazarus Source" SpriteToBitmap
ln -s "ExternalLibraries/GJHCustomComponents/Source" GJHCustomComponents
# to deal with the typo
ln -s "ExternalLibraries/GJHCustomComponents/Source" GJHCustomConponents

# to build from source
cd LazarusSource
lazbuild DiscImageManager.lpi --build-mode="Release Linux 64 bit" 

The symlinks can be made unnecessary by editing the search paths in the Lazarus project.

The other advantage of submodules is that Git will keep track of which versions of SpriteToBitmap and GJHCustomComponents are needed to build a particular version of Disc Image Manager.

I'm a little surprised that cloning the full repository takes 2.5 GiB of disk space, but that's something I've not looked into in detail. (edit: I looked at this, and there seems to have been a bunch of binary builds and zip files committed at some point in the past -- sadly there's no way to fix that without using "git rebase" which will change history and the commit IDs, which will in turn break people's forks)

[philpem]

I've done a quick PR for this - it's #40 linked above.

I've also implemented the submodules variation, it's quite simple and can be seen here:
https://github.com/philpem/DiscImageManager/tree/submodules
If it's of interest I can open a PR.