From d6464687c3cbfa9949c08a28a9a91392b06fb9f2 Mon Sep 17 00:00:00 2001
From: Burak Yigit Kaya <byk@sentry.io>
Date: Tue, 21 Apr 2026 20:12:08 +0000
Subject: [PATCH] ci: fix Node 20 + app-id deprecation warnings, refresh Node
 matrix
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Bump pnpm/action-setup from v4.3.0 (Node 20, deprecated) to v4.4.0
  (Node 24) across build.yml, lint.yml, docs-preview.yml. SHA pin
  preserved per third-party action convention.
- Rename 'app-id' to 'client-id' on actions/create-github-app-token@v3
  step in release.yml; v3.1.0+ deprecates app-id. Value unchanged —
  SENTRY_RELEASE_BOT_CLIENT_ID is already a client ID.
- Drop Node 20 from the build matrix, add Node 24.

Warnings observed in run 24743422957.
---
 .github/workflows/build.yml        | 8 ++++----
 .github/workflows/docs-preview.yml | 2 +-
 .github/workflows/lint.yml         | 2 +-
 .github/workflows/release.yml      | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 7a763679..336c192e 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -18,7 +18,7 @@ jobs:
       contents: read
     strategy:
       matrix:
-        node: ['20', '22']
+        node: ['22', '24']
     name: Node ${{ matrix.node }}
     steps:
       - uses: actions/checkout@v6
@@ -28,7 +28,7 @@ jobs:
       - name: Get pnpm version from Volta config
         id: pnpm-version
         run: echo "version=$(jq -r '.volta.pnpm' package.json)" >> $GITHUB_OUTPUT
-      - uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4.3.0
+      - uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
         with:
           version: ${{ steps.pnpm-version.outputs.version }}
       - uses: actions/cache@v5
@@ -57,7 +57,7 @@ jobs:
       - name: Get pnpm version from Volta config
         id: pnpm-version
         run: echo "version=$(jq -r '.volta.pnpm' package.json)" >> $GITHUB_OUTPUT
-      - uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4.3.0
+      - uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
         with:
           version: ${{ steps.pnpm-version.outputs.version }}
       - uses: actions/cache@v5
@@ -99,7 +99,7 @@ jobs:
       - name: Get pnpm version from Volta config
         id: pnpm-version
         run: echo "version=$(jq -r '.volta.pnpm' package.json)" >> $GITHUB_OUTPUT
-      - uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4.3.0
+      - uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
         with:
           version: ${{ steps.pnpm-version.outputs.version }}
       - name: Build Docs
diff --git a/.github/workflows/docs-preview.yml b/.github/workflows/docs-preview.yml
index 1f6682e6..7bcc1dd1 100644
--- a/.github/workflows/docs-preview.yml
+++ b/.github/workflows/docs-preview.yml
@@ -24,7 +24,7 @@ jobs:
       - name: Get pnpm version from Volta config
         id: pnpm-version
         run: echo "version=$(jq -r '.volta.pnpm' package.json)" >> $GITHUB_OUTPUT
-      - uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4.3.0
+      - uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
         with:
           version: ${{ steps.pnpm-version.outputs.version }}
 
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index 6d3e3bc3..ba05870c 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -19,7 +19,7 @@ jobs:
       - name: Get pnpm version from Volta config
         id: pnpm-version
         run: echo "version=$(jq -r '.volta.pnpm' package.json)" >> $GITHUB_OUTPUT
-      - uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4.3.0
+      - uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
         with:
           version: ${{ steps.pnpm-version.outputs.version }}
       - uses: actions/cache@v5
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 8285baa0..4e6c11ec 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -103,7 +103,7 @@ jobs:
         if: github.event_name == 'workflow_dispatch' && github.repository == 'getsentry/craft'
         uses: actions/create-github-app-token@v3
         with:
-          app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }}
+          client-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }}
           private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }}
 
       - uses: actions/checkout@v6