Skip to content

Commit ecd3f6e

Browse files
committed
merge: Update Data Collection stack
Bring the queue option removal and preceding stack updates into this layer.
2 parents 09e1448 + 6baa995 commit ecd3f6e

4 files changed

Lines changed: 2 additions & 25 deletions

File tree

sentry/api/sentry.api

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -391,13 +391,11 @@ public final class io/sentry/DataCollection {
391391
public fun getHttpBodies ()Ljava/util/Set;
392392
public fun getHttpHeaders ()Lio/sentry/DataCollection$HttpHeaders;
393393
public fun getQueryParams ()Lio/sentry/KeyValueCollectionBehavior;
394-
public fun getQueues ()Ljava/lang/Boolean;
395394
public fun getUserInfo ()Ljava/lang/Boolean;
396395
public fun setCookies (Lio/sentry/KeyValueCollectionBehavior;)V
397396
public fun setDatabaseQueryData (Z)V
398397
public fun setHttpBodies (Ljava/util/Set;)V
399398
public fun setQueryParams (Lio/sentry/KeyValueCollectionBehavior;)V
400-
public fun setQueues (Z)V
401399
public fun setUserInfo (Z)V
402400
}
403401

sentry/src/main/java/io/sentry/DataCollection.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ public final class DataCollection {
1616
private @Nullable KeyValueCollectionBehavior queryParams;
1717
private @Nullable Set<HttpBodyType> httpBodies;
1818
private @Nullable Boolean databaseQueryData;
19-
private @Nullable Boolean queues;
2019
private final @NotNull HttpHeaders httpHeaders = new HttpHeaders();
2120
private final @NotNull Graphql graphql = new Graphql();
2221

@@ -73,14 +72,6 @@ public void setDatabaseQueryData(final boolean databaseQueryData) {
7372
this.databaseQueryData = databaseQueryData;
7473
}
7574

76-
public @Nullable Boolean getQueues() {
77-
return queues;
78-
}
79-
80-
public void setQueues(final boolean queues) {
81-
this.queues = queues;
82-
}
83-
8475
public @NotNull HttpHeaders getHttpHeaders() {
8576
return httpHeaders;
8677
}
@@ -97,7 +88,6 @@ boolean isExplicitlyConfigured() {
9788
|| queryParams != null
9889
|| httpBodies != null
9990
|| databaseQueryData != null
100-
|| queues != null
10191
|| httpHeaders.hasOverrides()
10292
|| graphql.hasOverrides();
10393
}

sentry/src/test/java/io/sentry/DataCollectionTest.kt

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ class DataCollectionTest {
1414
assertThat(dataCollection.queryParams).isNull()
1515
assertThat(dataCollection.httpBodies).isNull()
1616
assertThat(dataCollection.databaseQueryData).isNull()
17-
assertThat(dataCollection.queues).isNull()
1817
assertThat(dataCollection.httpHeaders.request).isNull()
1918
assertThat(dataCollection.httpHeaders.response).isNull()
2019
assertThat(dataCollection.graphql.document).isNull()
@@ -82,16 +81,6 @@ class DataCollectionTest {
8281
assertThat(dataCollection.isExplicitlyConfigured()).isTrue()
8382
}
8483

85-
@Test
86-
fun `queues false is distinct from unset`() {
87-
val dataCollection = DataCollection(false)
88-
89-
dataCollection.setQueues(false)
90-
91-
assertThat(dataCollection.queues).isFalse()
92-
assertThat(dataCollection.isExplicitlyConfigured()).isTrue()
93-
}
94-
9584
@Test
9685
fun `nested HTTP header override marks configuration explicit`() {
9786
val dataCollection = DataCollection(false)

sentry/src/test/java/io/sentry/SentryOptionsTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,12 @@ class SentryOptionsTest {
5959
@Test
6060
fun `setting data collection replaces the default instance`() {
6161
val options = SentryOptions()
62-
val dataCollection = DataCollection().apply { setQueues(false) }
62+
val dataCollection = DataCollection().apply { setUserInfo(false) }
6363

6464
options.dataCollection = dataCollection
6565

6666
assertThat(options.dataCollection).isSameInstanceAs(dataCollection)
67-
assertThat(options.dataCollection.queues).isFalse()
67+
assertThat(options.dataCollection.userInfo).isFalse()
6868
}
6969

7070
@Test

0 commit comments

Comments
 (0)