add tests for when tracing is enabled

Author: Lms24

dev-packages/node-core-integration-tests/suites/tracing/traceid-recycling-with-spans/server.js

@@ -0,0 +1,23 @@
+const { loggingTransport } = require('@sentry-internal/node-core-integration-tests');
+const Sentry = require('@sentry/node-core');
+const { setupOtel } = require('../../../utils/setupOtel.js');
+
+const client = Sentry.init({
+  dsn: 'https://public@dsn.ingest.sentry.io/1337',
+  transport: loggingTransport,
+  tracesSampleRate: 1.0,
+});
+
+setupOtel(client);
+
+const express = require('express');
+const { startExpressServerAndSendPortToRunner } = require('@sentry-internal/node-core-integration-tests');
+
+const app = express();
+
+app.get('/test', (_req, res) => {
+  Sentry.captureException(new Error('test error'));
+  res.json({ success: true });
+});
+
+startExpressServerAndSendPortToRunner(app);

dev-packages/node-core-integration-tests/suites/tracing/traceid-recycling-with-spans/test.ts

@@ -0,0 +1,40 @@
+import { afterAll, expect, test } from 'vitest';
+import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
+
+afterAll(() => {
+  cleanupChildProcesses();
+});
+
+test('errors from in different requests each get a unique traceId when tracing is enabled', async () => {
+  const eventTraceIds: string[] = [];
+
+  const runner = createRunner(__dirname, 'server.js')
+    .expect({
+      event: event => {
+        eventTraceIds.push(event.contexts?.trace?.trace_id || '');
+      },
+    })
+    .expect({
+      event: event => {
+        eventTraceIds.push(event.contexts?.trace?.trace_id || '');
+      },
+    })
+    .expect({
+      event: event => {
+        // console.log('xx event 3');
+        eventTraceIds.push(event.contexts?.trace?.trace_id || '');
+      },
+    })
+    .start();
+
+  await runner.makeRequest('get', '/test');
+  await runner.makeRequest('get', '/test');
+  await runner.makeRequest('get', '/test');
+
+  await runner.completed();
+
+  expect(new Set(eventTraceIds).size).toBe(3);
+  for (const traceId of eventTraceIds) {
+    expect(traceId).toMatch(/^[a-f\d]{32}$/);
+  }
+});

dev-packages/node-integration-tests/suites/tracing/traceid-recycling-with-spans/server.ts

@@ -0,0 +1,23 @@
+import * as Sentry from '@sentry/node';
+import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
+
+Sentry.init({
+  dsn: 'https://public@dsn.ingest.sentry.io/1337',
+  release: '1.0',
+  transport: loggingTransport,
+  tracesSampleRate: 1.0,
+});
+
+import express from 'express';
+
+const app = express();
+
+app.get('/test', async (_req, res) => {
+  Sentry.captureException(new Error('test error'));
+  // calling Sentry.flush() here to ensure that the order in which we send transaction and errors
+  // is guaranteed to be 1. error, 2. transaction (repeated 3x in test)
+  await Sentry.flush();
+  res.json({ success: true });
+});
+
+startExpressServerAndSendPortToRunner(app);

dev-packages/node-integration-tests/suites/tracing/traceid-recycling-with-spans/test.ts

@@ -0,0 +1,57 @@
+import { afterAll, expect, test } from 'vitest';
+import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
+
+afterAll(() => {
+  cleanupChildProcesses();
+});
+
+test('errors and transactions get a unique traceId per request, when tracing is enabled', async () => {
+  const eventTraceIds: string[] = [];
+  const transactionTraceIds: string[] = [];
+
+  const runner = createRunner(__dirname, 'server.ts')
+    .expect({
+      event: event => {
+        eventTraceIds.push(event.contexts?.trace?.trace_id || '');
+      },
+    })
+    .expect({
+      transaction: transaction => {
+        transactionTraceIds.push(transaction.spans?.[0]?.trace_id || '');
+      },
+    })
+    .expect({
+      event: event => {
+        eventTraceIds.push(event.contexts?.trace?.trace_id || '');
+      },
+    })
+    .expect({
+      transaction: transaction => {
+        transactionTraceIds.push(transaction.spans?.[0]?.trace_id || '');
+      },
+    })
+    .expect({
+      event: event => {
+        eventTraceIds.push(event.contexts?.trace?.trace_id || '');
+      },
+    })
+    .expect({
+      transaction: transaction => {
+        transactionTraceIds.push(transaction.spans?.[0]?.trace_id || '');
+      },
+    })
+    .start();
+
+  await runner.makeRequest('get', '/test');
+  await runner.makeRequest('get', '/test');
+  await runner.makeRequest('get', '/test');
+
+  await runner.completed();
+
+  expect(new Set(transactionTraceIds).size).toBe(3);
+  for (const traceId of transactionTraceIds) {
+    expect(traceId).toMatch(/^[a-f\d]{32}$/);
+  }
+
+  expect(eventTraceIds).toEqual(transactionTraceIds);
+});