Skip to content

Commit fc4b3fa

Browse files
authored
ref(tests): Rename streamed http.client span test folders (#20602)
Follow-up to [#20420](#20420) — the `no-parent-span-client-report-streamed` test folders were originally testing client report outcomes, but that PR changed them to verify that http.client spans are emitted when streaming is enabled. Renames the folders to `http-client-span-streamed` to reflect what the tests actually assert, removes unused imports left over from the old test, and updates the node test's describe block name.
1 parent 2aa76b0 commit fc4b3fa

6 files changed

Lines changed: 2 additions & 7 deletions

File tree

dev-packages/browser-integration-tests/suites/tracing/no-parent-span-client-report-streamed/init.js renamed to dev-packages/browser-integration-tests/suites/tracing/http-client-span-streamed/init.js

File renamed without changes.

dev-packages/browser-integration-tests/suites/tracing/no-parent-span-client-report-streamed/subject.js renamed to dev-packages/browser-integration-tests/suites/tracing/http-client-span-streamed/subject.js

File renamed without changes.

dev-packages/browser-integration-tests/suites/tracing/no-parent-span-client-report-streamed/test.ts renamed to dev-packages/browser-integration-tests/suites/tracing/http-client-span-streamed/test.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
import { expect } from '@playwright/test';
22
import { sentryTest } from '../../../utils/fixtures';
3+
import { shouldSkipTracingTest } from '../../../utils/helpers';
34
import { getSpanOp, waitForStreamedSpan } from '../../../utils/spanUtils';
4-
import {
5-
envelopeRequestParser,
6-
hidePage,
7-
shouldSkipTracingTest,
8-
waitForClientReportRequest,
9-
} from '../../../utils/helpers';
105

116
sentryTest(
127
'sends http.client span for fetch requests without an active span when span streaming is enabled',

dev-packages/node-integration-tests/suites/tracing/no-parent-span-client-report-streamed/instrument.mjs renamed to dev-packages/node-integration-tests/suites/tracing/http-client-span-streamed/instrument.mjs

File renamed without changes.

dev-packages/node-integration-tests/suites/tracing/no-parent-span-client-report-streamed/scenario-fetch.mjs renamed to dev-packages/node-integration-tests/suites/tracing/http-client-span-streamed/scenario-fetch.mjs

File renamed without changes.

dev-packages/node-integration-tests/suites/tracing/no-parent-span-client-report-streamed/test.ts renamed to dev-packages/node-integration-tests/suites/tracing/http-client-span-streamed/test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { afterAll, describe, expect } from 'vitest';
22
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';
33

4-
describe('no_parent_span with streaming enabled', () => {
4+
describe('http.client span with streaming enabled', () => {
55
afterAll(() => {
66
cleanupChildProcesses();
77
});

0 commit comments

Comments
 (0)