ref: Remove transaction profiler in new major (#6921)

Closes #6920

Author: sentrivana

MIGRATION_GUIDE.md

@@ -26,6 +26,7 @@ Looking to upgrade from Sentry SDK 2.x to 3.x? Here's a comprehensive list of wh
 
 ## Removed
 
+- Transaction profiling and related code was removed.
 - Removed the deprecated Hub class and all uses of hub throughout the SDK in arguments, options, etc. Use a scope instead.
 - Removed the `auto_session_tracing` decorator. Use `track_session` instead.
 

docs/apidocs.rst

@@ -29,9 +29,6 @@ API Docs
 .. autoclass:: sentry_sdk.tracing.Span
    :members:
 
-.. autoclass:: sentry_sdk.profiler.transaction_profiler.Profile
-   :members:
-
 .. autoclass:: sentry_sdk.session.Session
    :members:
 

sentry_sdk/_types.py

@@ -274,7 +274,6 @@ class DataCollection(TypedDict):
             "monitor_config": Mapping[str, object],
             "monitor_slug": Optional[str],
             "platform": Literal["python"],
-            "profile": object,  # Should be sentry_sdk.profiler.Profile, but we can't import that here due to circular imports
             "release": Optional[str],
             "request": dict[str, object],
             "sdk": Mapping[str, object],
@@ -418,7 +417,6 @@ class DataCollection(TypedDict):
         "attachment",
         "session",
         "internal",
-        "profile",
         "profile_chunk",
         "monitor",
         "span",
@@ -429,7 +427,7 @@ class DataCollection(TypedDict):
     SessionStatus = Literal["ok", "exited", "crashed", "abnormal"]
 
     ContinuousProfilerMode = Literal["thread", "gevent", "unknown"]
-    ProfilerMode = Union[ContinuousProfilerMode, Literal["sleep"]]
+    ProfilerMode = Union[ContinuousProfilerMode]
 
     MonitorConfigScheduleType = Literal["crontab", "interval"]
     MonitorConfigScheduleUnit = Literal[

sentry_sdk/client.py

@@ -32,11 +32,6 @@
 from sentry_sdk.integrations.dedupe import DedupeIntegration
 from sentry_sdk.monitor import Monitor
 from sentry_sdk.profiler.continuous_profiler import setup_continuous_profiler
-from sentry_sdk.profiler.transaction_profiler import (
-    Profile,
-    has_profiling_enabled,
-    setup_profiler,
-)
 from sentry_sdk.scrubber import EventScrubber
 from sentry_sdk.serializer import serialize
 from sentry_sdk.sessions import SessionFlusher
@@ -632,7 +627,6 @@ def _record_lost_event(
                 self.options["send_default_pii"] = True
                 self.options["error_sampler"] = sample_all
                 self.options["traces_sampler"] = sample_all
-                self.options["profiles_sampler"] = sample_all
                 # data_collection was resolved in _get_options() before this
                 # spotlight override flipped send_default_pii on. Re-derive it so
                 # data_collection agrees with should_send_default_pii() in
@@ -708,20 +702,14 @@ def _record_lost_event(
             SDK_INFO["name"] = sdk_name
             logger.debug("Setting SDK name to '%s'", sdk_name)
 
-            if has_profiling_enabled(self.options):
-                try:
-                    setup_profiler(self.options)
-                except Exception as e:
-                    logger.debug("Can not set up profiler. (%s)", e)
-            else:
-                try:
-                    setup_continuous_profiler(
-                        self.options,
-                        sdk_info=SDK_INFO,
-                        capture_func=_capture_envelope,
-                    )
-                except Exception as e:
-                    logger.debug("Can not set up continuous profiler. (%s)", e)
+            try:
+                setup_continuous_profiler(
+                    self.options,
+                    sdk_info=SDK_INFO,
+                    capture_func=_capture_envelope,
+                )
+            except Exception as e:
+                logger.debug("Can not set up continuous profiler. (%s)", e)
 
         finally:
             _client_init_debug.set(old_debug)
@@ -733,7 +721,6 @@ def _record_lost_event(
             or self.log_batcher
             or self.metrics_batcher
             or self.span_batcher
-            or has_profiling_enabled(self.options)
             or isinstance(self.transport, HttpTransportCore)
         ):
             # If we have anything on that could spawn a background thread, we
@@ -1121,8 +1108,6 @@ def capture_event(
         if not self._should_capture(event, hint, scope):
             return None
 
-        profile = event.pop("profile", None)
-
         event_id = event.get("event_id")
         if event_id is None:
             event["event_id"] = event_id = uuid.uuid4().hex
@@ -1163,9 +1148,6 @@ def capture_event(
 
         envelope = Envelope(headers=headers)
 
-        if is_transaction and isinstance(profile, Profile):
-            envelope.add_profile(profile.to_json(event_opt, self.options))
-
         if is_transaction and not span_recorder_has_gen_ai_span:
             envelope.add_transaction(event_opt)
         elif is_transaction:

sentry_sdk/consts.py

@@ -1301,8 +1301,6 @@ def __init__(
         traces_sample_rate: "Optional[float]" = None,
         trace_lifecycle: "Optional[Literal['static', 'stream']]" = None,
         traces_sampler: "Optional[TracesSampler]" = None,
-        profiles_sample_rate: "Optional[float]" = None,
-        profiles_sampler: "Optional[TracesSampler]" = None,
         profiler_mode: "Optional[ProfilerMode]" = None,
         profile_lifecycle: 'Literal["manual", "trace"]' = "manual",
         profile_session_sample_rate: "Optional[float]" = None,
@@ -1705,16 +1703,6 @@ def __init__(
             Return a string for that repr value to be used or `None` to continue serializing how Sentry would have
             done it anyway.
 
-        :param profiles_sample_rate: A number between `0` and `1`, controlling the percentage chance a given sampled
-            transaction will be profiled.
-
-            (`0` represents 0% while `1` represents 100%.) Applies equally to all transactions created in the app.
-
-            This is relative to the tracing sample rate - e.g. `0.5` means 50% of sampled transactions will be
-            profiled.
-
-        :param profiles_sampler:
-
         :param profiler_mode:
 
         :param profile_lifecycle:

sentry_sdk/envelope.py

@@ -59,12 +59,6 @@ def add_transaction(
     ) -> None:
         self.add_item(Item(payload=PayloadRef(json=transaction), type="transaction"))
 
-    def add_profile(
-        self,
-        profile: "Any",
-    ) -> None:
-        self.add_item(Item(payload=PayloadRef(json=profile), type="profile"))
-
     def add_profile_chunk(
         self,
         profile_chunk: "Any",
@@ -259,8 +253,6 @@ def data_category(self) -> "EventDataCategory":
             return "trace_metric"
         elif ty == "client_report":
             return "internal"
-        elif ty == "profile":
-            return "profile"
         elif ty == "profile_chunk":
             return "profile_chunk"
         elif ty == "check_in":

sentry_sdk/integrations/django/asgi.py

@@ -188,10 +188,6 @@ async def sentry_wrapped_callback(
             if current_scope.transaction is not None:
                 current_scope.transaction.update_active_thread()
 
-        sentry_scope = sentry_sdk.get_isolation_scope()
-        if sentry_scope.profile is not None:
-            sentry_scope.profile.update_active_thread_id()
-
         integration = client.get_integration(DjangoIntegration)
         if not integration or not integration.middleware_spans:
             return await callback(request, *args, **kwargs)

sentry_sdk/integrations/django/views.py

@@ -99,12 +99,6 @@ def sentry_wrapped_callback(request: "Any", *args: "Any", **kwargs: "Any") -> "A
             if current_scope.transaction is not None:
                 current_scope.transaction.update_active_thread()
 
-        sentry_scope = sentry_sdk.get_isolation_scope()
-        # set the active thread id to the handler thread for sync views
-        # this isn't necessary for async views since that runs on main
-        if sentry_scope.profile is not None:
-            sentry_scope.profile.update_active_thread_id()
-
         integration = client.get_integration(DjangoIntegration)
         if not integration or not integration.middleware_spans:
             return callback(request, *args, **kwargs)

sentry_sdk/integrations/fastapi.py

@@ -181,10 +181,6 @@ def _sentry_call(*args: "Any", **kwargs: "Any") -> "Any":
                 elif current_scope.transaction is not None:
                     current_scope.transaction.update_active_thread()
 
-                sentry_scope = sentry_sdk.get_isolation_scope()
-                if sentry_scope.profile is not None:
-                    sentry_scope.profile.update_active_thread_id()
-
                 return old_call(*args, **kwargs)
 
             _sentry_call._sentry_is_patched = True  # type: ignore[attr-defined]

sentry_sdk/integrations/quart.py

@@ -133,10 +133,6 @@ def _sentry_func(*args: "Any", **kwargs: "Any") -> "Any":
                         if current_scope.transaction is not None:
                             current_scope.transaction.update_active_thread()
 
-                    sentry_scope = sentry_sdk.get_isolation_scope()
-                    if sentry_scope.profile is not None:
-                        sentry_scope.profile.update_active_thread_id()
-
                     return old_func(*args, **kwargs)
 
                 return old_decorator(_sentry_func)