Godot Module

[Ughuuu]

Probably outside of the scope of this, since the name is lua-gdextension, but still thought of making the issue to ask. Would there be any want to make either a module version of this or support both?
Use case would be to have it pre-built into engine (not mainstream godot, unless they deem it fit), so its easier to install on every new project.

[gilzoide]

Hey @Ughuuu, thanks for the question.

Honestly, for me, if a GDExtension can solve the problem, I prefer implementing it as a GDExtension rather than an engine module. Much more people will be able to use it that way.

so its easier to install on every new project.

There could be a GitHub template repo that's a Godot project with Lua GDExtension preinstalled. Or a project in Godot Asset Library that you import and change afterwards (also a template).

But feel free to fork this project and implement it, open a PR if you can make the project work as a GDExtension and engine module if it does not make everything too complex.

[Ughuuu]

Since making this issue, I have successfully ported 2 gdextensions to modules (Without big codechanges to the gdextension, just adding 2 new files). I'm still investigating if using this gdextension is right for me, but if I do use it, I would greatly prefer a module, as I am using the engine with all modules I use prebuilt in it.

• Example A: https://github.com/libriscv/godot-sandbox ( SCsub file and register_types.h and register_types.cpp, thats all thats needed for the module wrapper)
• Example B: https://github.com/appsinacup/tiny_lobby

From here, I simply add the repo as a submodule to godot in the modules folder, and then build.

So, to reiterate, the actual change needed here, if wanted, would now be to add those 3 new files, so no need to rewrite it as a module.

If the change is not that big, would you reconsider having it in the repo? Also, do you by any chance have a discord group/server?

[gilzoide]

Hey @Ughuuu, thanks for the additional info.

If the change is not that big, would you reconsider having it in the repo?

I have no restrictions as to implementing Lua GDExtension as a Godot module, I just won't work on it.
But feel free to open a PR implementing it =]
As you said, it seems to be only 3 additional files, so my "if it does not make everything too complex" checkbox seems to be checked, so go for it!

Also, do you by any chance have a discord group/server?

No, we do not. Feel free to create one, we can add a link to the README and maybe in the Asset Library description for people to find it.
I'm not a big Discord user and prefer to use GitHub Issues / Discussions, but by no means there shouldn't be one, just let me know if you do create it so we can gather people there.

[Ughuuu]

Thanks for answering. I believe if you won't be on it, probl it's not worth creating it. I wouldn't go there if I can't find you there :D.
Ok, will try to make a PR maybe then.

[gilzoide]

I believe if you won't be on it, probl it's not worth creating it. I wouldn't go there if I can't find you there

Well, I would enter the Disc server, just wouldn't be as responsive as in here 😅 Unless tagged, I think I do get notifications in those cases 🤔 But I do prefer the forum-like format of GitHub, everything stays documented, people can search for an Issue before questioning the same thing again, this kind of thing. It's more ok to take some time to answer... =P
But again, if you think it would be a nice addition for the ecosystem, feel free to create it!

[Ughuuu]

Would you be ok if I reuse my already existing server (that I use for other addons I develop) and make a channel there, or want a completely new discord server specifically for this? (on my existing server I mainly talk about game development, godot-rapier, tiny_lobby, etc.)

[gilzoide]

Would you be ok if I reuse my already existing server (that I use for other addons I develop) and make a channel there, or want a completely new discord server specifically for this? (on my existing server I mainly talk about game development, godot-rapier, tiny_lobby, etc.)

I'd say creating a new server would make it more self contained, but I don't really mind if you reuse your existing server for this, feel free to choose this one.