Skip to content

Commit a568bf4

Browse files
committed
Use the new dataflow module wherever possible without affecting any test behavior
- Updated various QL files to replace deprecated 'DataFlow' and 'TaintTracking' imports with 'new.DataFlow' and 'new.TaintTracking'. - Removed warnings related to deprecated modules in test expectations for affected rules.
1 parent 883a46f commit a568bf4

95 files changed

Lines changed: 82 additions & 219 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

c/cert/src/rules/CON30-C/CleanUpThreadSpecificStorage.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import cpp
2121
import codingstandards.c.cert
2222
import codingstandards.cpp.Concurrency
23-
import semmle.code.cpp.dataflow.DataFlow
23+
import semmle.code.cpp.dataflow.new.DataFlow
2424

2525
module TssCreateToTssDeleteConfig implements DataFlow::ConfigSig {
2626
predicate isSource(DataFlow::Node node) {

c/cert/src/rules/ERR30-C/ErrnoReadBeforeReturn.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import cpp
2020
import codingstandards.c.cert
2121
import codingstandards.c.Errno
22-
import semmle.code.cpp.dataflow.DataFlow
22+
import semmle.code.cpp.dataflow.new.DataFlow
2323

2424
/**
2525
* A call to an `OutOfBandErrnoSettingFunction`

c/cert/src/rules/ERR30-C/SetlocaleMightSetErrno.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import cpp
1919
import codingstandards.c.cert
2020
import codingstandards.c.Errno
21-
import semmle.code.cpp.dataflow.DataFlow
21+
import semmle.code.cpp.dataflow.new.DataFlow
2222

2323
class SetlocaleFunctionCall extends FunctionCall {
2424
SetlocaleFunctionCall() { this.getTarget().hasGlobalName("setlocale") }

c/cert/src/rules/ERR32-C/DoNotRelyOnIndeterminateValuesOfErrno.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import codingstandards.c.cert
2020
import codingstandards.c.Errno
2121
import codingstandards.c.Signal
2222
import semmle.code.cpp.controlflow.Guards
23-
import semmle.code.cpp.dataflow.DataFlow
23+
import semmle.code.cpp.dataflow.new.DataFlow
2424

2525
/**
2626
* A check on `signal` call return value

c/cert/src/rules/ERR33-C/DetectAndHandleStandardLibraryErrors.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import cpp
2020
import codingstandards.c.cert
2121
import semmle.code.cpp.commons.NULL
2222
import codingstandards.cpp.ReadErrorsAndEOF
23-
import semmle.code.cpp.dataflow.DataFlow
23+
import semmle.code.cpp.dataflow.new.DataFlow
2424

2525
ComparisonOperation getAValidComparison(string spec) {
2626
spec = "=0" and result.(EqualityOperation).getAnOperand().getValue() = "0"

c/cert/src/rules/EXP30-C/DependenceOnOrderOfFunctionArgumentsForSideEffects.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import cpp
2020
import codingstandards.c.cert
2121
import codingstandards.cpp.SideEffect
22-
import semmle.code.cpp.dataflow.TaintTracking
22+
import semmle.code.cpp.dataflow.new.TaintTracking
2323
import semmle.code.cpp.valuenumbering.GlobalValueNumbering
2424

2525
/** Holds if the function's return value is derived from the `AliasParamter` p. */

c/cert/src/rules/FIO37-C/SuccessfulFgetsOrFgetwsMayReturnAnEmptyString.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import cpp
1919
import codingstandards.c.cert
2020
import codingstandards.cpp.FgetsErrorManagement
2121
import codingstandards.cpp.Dereferenced
22-
import semmle.code.cpp.dataflow.DataFlow
22+
import semmle.code.cpp.dataflow.new.DataFlow
2323

2424
/*
2525
* CFG nodes that follows a successful call to `fgets`

c/cert/src/rules/FIO40-C/ResetStringsOnFgetsOrFgetwsFailure.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import cpp
2121
import codingstandards.cpp.FgetsErrorManagement
2222
import codingstandards.cpp.Dereferenced
2323
import codingstandards.c.cert
24-
import semmle.code.cpp.dataflow.DataFlow
24+
import semmle.code.cpp.dataflow.new.DataFlow
2525

2626
/*
2727
* Models calls to `memcpy` `strcpy` `strncpy` and their wrappers

c/cert/src/rules/FIO45-C/ToctouRaceConditionsWhileAccessingFiles.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import cpp
2020
import codingstandards.c.cert
2121
import codingstandards.cpp.standardlibrary.FileAccess
22-
import semmle.code.cpp.dataflow.DataFlow
22+
import semmle.code.cpp.dataflow.new.DataFlow
2323
import semmle.code.cpp.valuenumbering.GlobalValueNumbering
2424

2525
/**

c/cert/src/rules/MEM35-C/InsufficientMemoryAllocatedForObject.ql

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import cpp
2121
import codingstandards.c.cert
2222
import codingstandards.cpp.Overflow
2323
import semmle.code.cpp.controlflow.Guards
24-
import semmle.code.cpp.dataflow.TaintTracking
2524
import semmle.code.cpp.models.Models
2625

2726
/**

0 commit comments

Comments
 (0)