Java: Convert org.apache.http.Http*.get* methods to CSV based flow source

Author: tamasvajk

java/ql/src/semmle/code/java/dataflow/ExternalFlow.qll

@@ -136,7 +136,10 @@ private predicate sourceModelCsv(string row) {
       // CookieGet*
       "javax.servlet.http;Cookie;false;getValue;();;ReturnValue;remote",
       "javax.servlet.http;Cookie;false;getName;();;ReturnValue;remote",
-      "javax.servlet.http;Cookie;false;getComment;();;ReturnValue;remote"
+      "javax.servlet.http;Cookie;false;getComment;();;ReturnValue;remote",
+      // ApacheHttp*
+      "org.apache.http;HttpMessage;false;getParams;();;ReturnValue;remote",
+      "org.apache.http;HttpEntity;false;getContent;();;ReturnValue;remote"
     ]
 }
 

java/ql/src/semmle/code/java/dataflow/FlowSources.qll

@@ -216,8 +216,6 @@ private class RemoteTaintedMethod extends Method {
   RemoteTaintedMethod() {
     this instanceof PlayRequestGetMethod or
     this instanceof SpringRestTemplateResponseEntityMethod or
-    this instanceof ApacheHttpGetParams or
-    this instanceof ApacheHttpEntityGetContent or
     // In the setting of Android we assume that XML has been transmitted over
     // the network, so may be tainted.
     this instanceof XmlPullGetMethod or