Update cpp/ql/src/experimental/Security/CWE/CWE-14/CompilerRemovalOfCodeToClearBuffers.ql

ihsinme · MathiasVP · web-flow · commit 1c4610c72295 · 2021-01-14T17:15:36.000+03:00
Co-authored-by: Mathias Vorreiter Pedersen &lt;mathiasvp@github.com&gt;
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-14/CompilerRemovalOfCodeToClearBuffers.ql b/cpp/ql/src/experimental/Security/CWE/CWE-14/CompilerRemovalOfCodeToClearBuffers.ql
@@ -38,10 +38,9 @@ class CompilerRemovaMemset extends FunctionCall {
   }
 
   predicate isExistsFreeForThisVariable() {
-    exists(FunctionCall free, Variable v |
-      free instanceof DeallocationExpr and
+    exists(DeallocationExpr free, Variable v |
       this.getArgument(0) = v.getAnAccess() and
-      free.getArgument(0) = v.getAnAccess() and
+      free.getFreedExpr() = v.getAnAccess() and
       this.getASuccessor+() = free
     )
   }

Original file line number	Diff line number	Diff line change
`@@ -38,10 +38,9 @@ class CompilerRemovaMemset extends FunctionCall {`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`predicate isExistsFreeForThisVariable() {`
`41`		`- exists(FunctionCall free, Variable v \|`
`42`		`- free instanceof DeallocationExpr and`
	`41`	`+ exists(DeallocationExpr free, Variable v \|`
`43`	`42`	`this.getArgument(0) = v.getAnAccess() and`
`44`		`- free.getArgument(0) = v.getAnAccess() and`
	`43`	`+ free.getFreedExpr() = v.getAnAccess() and`
`45`	`44`	`this.getASuccessor+() = free`
`46`	`45`	`)`
`47`	`46`	`}`