change getAnElementRead to getASubstringRead

Author: erik-krogh

javascript/ql/src/Security/CWE-020/IncompleteUrlSchemeCheck.ql

@@ -29,7 +29,7 @@ DataFlow::SourceNode schemeOf(DataFlow::Node url) {
   // url.split(":")[0]
   exists(StringSplitCall split |
     split.getSeparator() = ":" and
-    result = split.getAnElementRead(0) and
+    result = split.getASubstringRead(0) and
     url = split.getBaseString()
   )
   or

javascript/ql/src/semmle/javascript/StandardLibrary.qll

@@ -178,5 +178,5 @@ class StringSplitCall extends DataFlow::MethodCallNode {
    * Gets a read of the `i`th element from the split string.
    */
   bindingset[i]
-  DataFlow::Node getAnElementRead(int i) { result = getAPropertyRead(i.toString()) }
+  DataFlow::Node getASubstringRead(int i) { result = getAPropertyRead(i.toString()) }
 }

javascript/ql/src/semmle/javascript/security/dataflow/Xss.qll

@@ -285,7 +285,7 @@ module DomBasedXss {
     StringSplitCall splitCall;
 
     QueryPrefixSanitizer() {
-      this = splitCall.getAnElementRead(0) and
+      this = splitCall.getASubstringRead(0) and
       splitCall.getSeparator() = "?" and
       splitCall.getBaseString().getALocalSource() = [DOM::locationRef(), DOM::locationRef().getAPropertyRead("href")]
     }