Address review comments

Author: knewbury01

actions/ql/lib/actions.qll

@@ -1,3 +1 @@
 import codeql.actions.Ast
-
-abstract class CustomEnvEnable extends Environment { }

actions/ql/lib/codeql/actions/config/Config.qll

@@ -173,10 +173,3 @@ predicate actionsPermissionsDataModel(string action, string permission) {
 predicate enabledDeploymentEnvironmentDataModel(string name) {
   Extensions::enabledDeploymentEnvironmentDataModel(name)
 }
-
-/**
- * `EnvironmentCheck` implementation model.
- */
-predicate selectDeploymentEnvironmentDataModel(string selected) {
-  Extensions::selectDeploymentEnvironmentDataModel(selected)
-}

actions/ql/lib/codeql/actions/config/ConfigExtensions.qll

@@ -95,8 +95,3 @@ extensible predicate actionsPermissionsDataModel(string action, string permissio
  * toggle precision of whether that suffices or not as a control check.
  */
 extensible predicate enabledDeploymentEnvironmentDataModel(string name);
-
-/**
- * Selects which deployment environments model to use to implement `EnvironmentCheck`.
- */
-extensible predicate selectDeploymentEnvironmentDataModel(string mechanism);

actions/ql/lib/codeql/actions/security/ControlChecks.qll

@@ -278,15 +278,10 @@ abstract class LabelCheck extends ControlCheck {
 
 class EnvironmentCheck extends ControlCheck instanceof Environment {
   EnvironmentCheck() {
-    exists(string selected |
-      selectDeploymentEnvironmentDataModel(selected) and
-      if selected = "EnvironmentCheckMaD"
-      then enabledDeploymentEnvironmentDataModel(this.(Environment).getName())
-      else
-        if selected = "EnvironmentCheckCustomQL"
-        then this instanceof CustomEnvEnable
-        else this instanceof Environment
-    )
+    // if there are any custom tuples use those
+    if enabledDeploymentEnvironmentDataModel(_)
+    then enabledDeploymentEnvironmentDataModel(this.(Environment).getName())
+    else this instanceof Environment
   }
 
   // Environment checks are not effective against any mutable attacks

actions/ql/lib/ext/config/customize_checks.yml

@@ -2,5 +2,4 @@ extensions:
   - addsTo:
       pack: codeql/actions-all
       extensible: enabledDeploymentEnvironmentDataModel
-    data: 
-      - [""]
+    data: []