Exclude constants

joefarebrother · joefarebrother · commit 594d51e84d78 · 2022-03-11T17:45:42.000Z
diff --git a/java/ql/lib/semmle/code/java/security/SensitiveLoggingQuery.qll b/java/ql/lib/semmle/code/java/security/SensitiveLoggingQuery.qll
@@ -10,7 +10,8 @@ import DataFlow
 class CredentialExpr extends Expr {
   CredentialExpr() {
     exists(Variable v | this = v.getAnAccess() |
-      v.getName().regexpMatch([getCommonSensitiveInfoRegex(), "(?i).*(username).*"])
+      v.getName().regexpMatch([getCommonSensitiveInfoRegex(), "(?i).*(username).*"]) and
+      not v.isFinal()
     )
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,8 @@ import DataFlow`
`10`	`10`	`class CredentialExpr extends Expr {`
`11`	`11`	`CredentialExpr() {`
`12`	`12`	`exists(Variable v \| this = v.getAnAccess() \|`
`13`		`- v.getName().regexpMatch([getCommonSensitiveInfoRegex(), "(?i).(username)."])`
	`13`	`+ v.getName().regexpMatch([getCommonSensitiveInfoRegex(), "(?i).(username)."]) and`
	`14`	`+ not v.isFinal()`
`14`	`15`	`)`
`15`	`16`	`}`
`16`	`17`	`}`