Skip to content

Commit 5b66a15

Browse files
committed
Extend mayBeDangerous() QLDoc
1 parent 15dfc6d commit 5b66a15

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

python/ql/src/experimental/semmle/python/Concepts.qll

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,9 @@ module XMLParsing {
9797

9898
/**
9999
* Holds if the parser may be parsing the input dangerously.
100+
*
101+
* Specifically, this predicate holds whether the XML parsing parses/extends external
102+
* entities in the parsed XML stream.
100103
*/
101104
abstract predicate mayBeDangerous();
102105
}
@@ -115,6 +118,9 @@ class XMLParsing extends DataFlow::Node {
115118

116119
/**
117120
* Gets the argument containing the content to parse.
121+
*
122+
* Specifically, this predicate holds whether the XML parsing parses/extends external
123+
* entities in the parsed XML stream.
118124
*/
119125
DataFlow::Node getAnInput() { result = range.getAnInput() }
120126

@@ -140,6 +146,9 @@ module XMLParser {
140146

141147
/**
142148
* Holds if the parser may be dangerously configured.
149+
*
150+
* Specifically, this predicate holds whether the XML parser parses/extends external
151+
* entities in the parsed XML stream.
143152
*/
144153
abstract predicate mayBeDangerous();
145154
}
@@ -163,6 +172,9 @@ class XMLParser extends DataFlow::Node {
163172

164173
/**
165174
* Holds if the parser may be dangerously configured.
175+
*
176+
* Specifically, this predicate holds whether the XML parser parses/extends external
177+
* entities in the parsed XML stream.
166178
*/
167179
predicate mayBeDangerous() { range.mayBeDangerous() }
168180
}

0 commit comments

Comments
 (0)