Play remote source update to return functionaccessexpr

torque59 · torque59 · commit 5d5b84974bd8 · 2020-10-22T22:29:43.000+05:30
diff --git a/java/ql/src/semmle/code/java/dataflow/FlowSources.qll b/java/ql/src/semmle/code/java/dataflow/FlowSources.qll
@@ -127,7 +127,7 @@ private class SpringMultipartRequestSource extends RemoteFlowSource {
 class PlayParameterSource extends RemoteFlowSource {
   PlayParameterSource() {
     exists(PlayActionMethodQueryParameter p | p = this.asParameter()) or
-    exists(PlayMVCHTTPRequestHeaderMethods m | m.getQueryString().getAnArgument() = this.asExpr())
+    exists(PlayMVCHTTPRequestHeaderMethods m | m.getQueryString() = this.asExpr())
   }
 
   override string getSourceType() { result = "Play Query Parameters" }

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ private class SpringMultipartRequestSource extends RemoteFlowSource {`
`127`	`127`	`class PlayParameterSource extends RemoteFlowSource {`
`128`	`128`	`PlayParameterSource() {`
`129`	`129`	`exists(PlayActionMethodQueryParameter p \| p = this.asParameter()) or`
`130`		`- exists(PlayMVCHTTPRequestHeaderMethods m \| m.getQueryString().getAnArgument() = this.asExpr())`
	`130`	`+ exists(PlayMVCHTTPRequestHeaderMethods m \| m.getQueryString() = this.asExpr())`
`131`	`131`	`}`
`132`	`132`
`133`	`133`	`override string getSourceType() { result = "Play Query Parameters" }`