Remove redundant IEntity implemented interface declaration and explit interface member implemenration

Author: tamasvajk

csharp/extractor/Semmle.Extraction.CIL/Entities/Field.cs

@@ -61,7 +61,7 @@ public void Extract(Context cx2)
             cx2.Populate(this);
         }
 
-        TrapStackBehaviour IEntity.TrapStackBehaviour => TrapStackBehaviour.NoLabel;
+        public TrapStackBehaviour TrapStackBehaviour => TrapStackBehaviour.NoLabel;
 
         public abstract IEnumerable<Type> TypeParameters { get; }
 

csharp/extractor/Semmle.Extraction.CIL/Entities/Instruction.cs

@@ -8,7 +8,7 @@ namespace Semmle.Extraction.CIL.Entities
     /// <summary>
     /// A CIL instruction.
     /// </summary>
-    internal class Instruction : UnlabelledEntity, IEntity
+    internal class Instruction : UnlabelledEntity
     {
         /// <summary>
         /// The additional data following the opcode, if any.
@@ -289,11 +289,6 @@ public int Width
             }
         }
 
-        Label IEntity.Label
-        {
-            get; set;
-        }
-
         private readonly byte[] data;
 
         private int PayloadSize => payloadSizes[(int)PayloadType];

csharp/extractor/Semmle.Extraction.CIL/Entities/TypeContainer.cs

@@ -31,8 +31,6 @@ public void WriteQuotedId(TextWriter trapFile)
 
         public abstract string IdSuffix { get; }
 
-        Location IEntity.ReportingLocation => throw new NotImplementedException();
-
         public void Extract(Context cx2) { cx2.Populate(this); }
 
         public abstract IEnumerable<IExtractionProduct> Contents { get; }
@@ -44,7 +42,8 @@ public override string ToString()
             return writer.ToString();
         }
 
-        TrapStackBehaviour IEntity.TrapStackBehaviour => TrapStackBehaviour.NoLabel;
+        public TrapStackBehaviour TrapStackBehaviour => TrapStackBehaviour.NoLabel;
+        public Location ReportingLocation => throw new NotImplementedException();
 
         public abstract IEnumerable<Type> MethodParameters { get; }
         public abstract IEnumerable<Type> TypeParameters { get; }

csharp/extractor/Semmle.Extraction.CIL/ExtractionProduct.cs

@@ -71,7 +71,7 @@ protected UnlabelledEntity(Context cx)
             cx.Cx.AddFreshLabel(this);
         }
 
-        TrapStackBehaviour IEntity.TrapStackBehaviour => TrapStackBehaviour.NoLabel;
+        public TrapStackBehaviour TrapStackBehaviour => TrapStackBehaviour.NoLabel;
     }
 
     /// <summary>
@@ -115,7 +115,7 @@ public override string ToString()
             return writer.ToString();
         }
 
-        TrapStackBehaviour IEntity.TrapStackBehaviour => TrapStackBehaviour.NoLabel;
+        public TrapStackBehaviour TrapStackBehaviour => TrapStackBehaviour.NoLabel;
     }
 
     /// <summary>