Example fixes

torque59 · torque59 · commit 75b79039a1c4 · 2021-01-24T20:46:37.000+05:30
diff --git a/java/ql/src/Security/CWE/CWE-346/UnvalidatedCors.java b/java/ql/src/Security/CWE/CWE-346/UnvalidatedCors.java
@@ -21,10 +21,10 @@ public void doFilter(ServletRequest req, ServletResponse res,
         String url = request.getHeader("Origin");
 
         if (!StringUtils.isEmpty(url)) {
-            String val = response.getHeader("Access-Control-Allow-Origin"); // BAD -> User controlled CORS header.
+            String val = response.getHeader("Access-Control-Allow-Origin");
 
             if (StringUtils.isEmpty(val)) {
-                response.addHeader("Access-Control-Allow-Origin", url);
+                response.addHeader("Access-Control-Allow-Origin", url); // BAD -> User controlled CORS header being set here.
                 response.addHeader("Access-Control-Allow-Credentials", "true");
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -21,10 +21,10 @@ public void doFilter(ServletRequest req, ServletResponse res,`
`21`	`21`	`String url = request.getHeader("Origin");`
`22`	`22`
`23`	`23`	`if (!StringUtils.isEmpty(url)) {`
`24`		`- String val = response.getHeader("Access-Control-Allow-Origin"); // BAD -> User controlled CORS header.`
	`24`	`+ String val = response.getHeader("Access-Control-Allow-Origin");`
`25`	`25`
`26`	`26`	`if (StringUtils.isEmpty(val)) {`
`27`		`- response.addHeader("Access-Control-Allow-Origin", url);`
	`27`	`+ response.addHeader("Access-Control-Allow-Origin", url); // BAD -> User controlled CORS header being set here.`
`28`	`28`	`response.addHeader("Access-Control-Allow-Credentials", "true");`
`29`	`29`	`}`
`30`	`30`	`}`