Inline getOptionsArgument

Author: edvraa

javascript/ql/src/semmle/javascript/dataflow/Nodes.qll

@@ -169,7 +169,7 @@ class InvokeNode extends DataFlow::SourceNode {
    * Holds if the `i`th argument of this invocation is an object literal set to `result`.
    */
   pragma[noinline]
-  ObjectLiteralNode getOptionsArgument(int i) { result.flowsTo(getArgument(i)) }
+  private ObjectLiteralNode getOptionsArgument(int i) { result.flowsTo(getArgument(i)) }
 
   /** Gets an abstract value representing possible callees of this call site. */
   final AbstractValue getACalleeValue() {

javascript/ql/src/semmle/javascript/security/InsecureCookie.qll

@@ -75,7 +75,7 @@ module Cookie {
   class InsecureCookieSession extends ExpressLibraries::CookieSession::MiddlewareInstance, Cookie {
     override string getKind() { result = "cookie-session" }
 
-    override DataFlow::SourceNode getCookieOptionsArgument() { result = this.getOptionsArgument(0) }
+    override DataFlow::SourceNode getCookieOptionsArgument() { result.flowsTo(getArgument(0)) }
 
     private DataFlow::Node getCookieFlagValue(string flag) {
       result = this.getCookieOptionsArgument().getAPropertyWrite(flag).getRhs()