C#: Extract record declarations

Author: tamasvajk

csharp/extractor/Semmle.Extraction.CSharp/Populators/TypeContainerVisitor.cs

@@ -43,6 +43,11 @@ public override void VisitDelegateDeclaration(DelegateDeclarationSyntax node)
             Entities.NamedType.Create(cx, cx.GetModel(node).GetDeclaredSymbol(node)).ExtractRecursive(trapFile, parent);
         }
 
+        public override void VisitRecordDeclaration(RecordDeclarationSyntax node)
+        {
+            Entities.Type.Create(cx, cx.GetModel(node).GetDeclaredSymbol(node)).ExtractRecursive(trapFile, parent);
+        }
+
         public override void VisitClassDeclaration(ClassDeclarationSyntax classDecl)
         {
             Entities.Type.Create(cx, cx.GetModel(classDecl).GetDeclaredSymbol(classDecl)).ExtractRecursive(trapFile, parent);

csharp/ql/src/semmle/code/csharp/PrintAst.qll

@@ -102,15 +102,16 @@ private ValueOrRefType getAnInterestingBaseType(ValueOrRefType type) {
   not type instanceof ArrayType and
   not type instanceof NullableType and
   result = type.getABaseType() and
-  isInterestingBaseType(result)
+  isInterestingBaseType(type, result)
 }
 
-private predicate isInterestingBaseType(ValueOrRefType base) {
+private predicate isInterestingBaseType(ValueOrRefType type, ValueOrRefType base) {
   not base instanceof ObjectType and
   not base.getQualifiedName() = "System.ValueType" and
   not base.getQualifiedName() = "System.Delegate" and
   not base.getQualifiedName() = "System.MulticastDelegate" and
-  not base.getQualifiedName() = "System.Enum"
+  not base.getQualifiedName() = "System.Enum" and
+  exists(TypeMention tm | tm.getTarget() = type and tm.getType() = base)
 }
 
 /**

csharp/ql/test/library-tests/csharp9/InitOnlyProperty.cs

@@ -1,12 +1,5 @@
 using System;
 
-namespace System.Runtime.CompilerServices
-{
-    public sealed class IsExternalInit
-    {
-    }
-}
-
 public class Base
 {
     public int Prop0 { get { return 1; } init { Prop1 = value; } }

csharp/ql/test/library-tests/csharp9/IsExternalInit.cs

@@ -0,0 +1,7 @@
+using System;
+using System.Text;
+
+namespace System.Runtime.CompilerServices
+{
+    public class IsExternalInit { }
+}