Update WrongInDetectingAndHandlingMemoryAllocationErrors.ql

ihsinme · web-flow · commit c8eeb5f73e70 · 2021-01-29T11:51:15.000+03:00
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-570/WrongInDetectingAndHandlingMemoryAllocationErrors.ql b/cpp/ql/src/experimental/Security/CWE/CWE-570/WrongInDetectingAndHandlingMemoryAllocationErrors.ql
@@ -22,6 +22,9 @@ class IfCompareWithZero extends IfStmt {
     or
     this.getCondition().(NEExpr).getAChild().getValue() = "0" and
     this.hasElse()
+    or
+    this.getCondition().(NEExpr).getAChild().getValue() = "0" and
+    this.getThen().getAChild*() instanceof ReturnStmt
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,9 @@ class IfCompareWithZero extends IfStmt {`
`22`	`22`	`or`
`23`	`23`	`this.getCondition().(NEExpr).getAChild().getValue() = "0" and`
`24`	`24`	`this.hasElse()`
	`25`	`+ or`
	`26`	`+ this.getCondition().(NEExpr).getAChild().getValue() = "0" and`
	`27`	`+ this.getThen().getAChild*() instanceof ReturnStmt`
`25`	`28`	`}`
`26`	`29`	`}`
`27`	`30`