Remove some 'any' types from 4 files (#61660)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: heiskr

eslint.config.ts

@@ -234,20 +234,16 @@ export default [
   // Legacy files with @typescript-eslint/no-explicit-any violations (see github/docs-engineering#5797)
   {
     files: [
-      'src/article-api/transformers/audit-logs-transformer.ts',
       'src/article-api/transformers/rest-transformer.ts',
       'src/content-render/unified/annotate.ts',
       'src/frame/components/context/MainContext.tsx',
       'src/landings/components/CookBookFilter.tsx',
       'src/languages/lib/correct-translation-content.ts',
-      'src/languages/lib/render-with-fallback.ts',
       'src/search/components/hooks/useAISearchAutocomplete.ts',
       'src/search/components/hooks/useAISearchLocalStorageCache.ts',
       'src/search/components/input/SearchOverlay.tsx',
       'src/search/lib/get-elasticsearch-results/ai-search-autocomplete.ts',
       'src/search/lib/get-elasticsearch-results/general-search.ts',
-      'src/search/lib/routes/combined-search-route.ts',
-      'src/search/lib/search-request-params/get-search-from-request-params.ts',
       'src/search/scripts/index/index-cli.ts',
       'src/search/scripts/index/utils/indexing-elasticsearch-utils.ts',
     ],

src/article-api/transformers/audit-logs-transformer.ts

@@ -1,6 +1,7 @@
 import type { Context, Page } from '@/types'
 import type { PageTransformer } from './types'
 import type { CategorizedEvents } from '@/audit-logs/types'
+import type { TitleResolutionContext } from '@/audit-logs/lib/index'
 import { renderContent } from '@/content-render/index'
 import { loadTemplate } from '@/article-api/lib/load-template'
 import matter from '@gr2m/gray-matter'
@@ -94,7 +95,10 @@ export class AuditLogsTransformer implements PageTransformer {
     categoryNotes: Record<string, string>,
     context: Context,
     manualContent: string,
-    resolveReferenceLinksToMarkdown: (docsReferenceLinks: string, context: any) => Promise<string>,
+    resolveReferenceLinksToMarkdown: (
+      docsReferenceLinks: string,
+      context: TitleResolutionContext,
+    ) => Promise<string>,
   ): Promise<Record<string, unknown>> {
     // Prepare page intro
     const intro = page.intro ? await page.renderProp('intro', context, { textOnly: true }) : ''
@@ -115,7 +119,7 @@ export class AuditLogsTransformer implements PageTransformer {
           if (newEvent.docs_reference_links && newEvent.docs_reference_links !== 'N/A') {
             newEvent.docs_reference_links = await resolveReferenceLinksToMarkdown(
               newEvent.docs_reference_links,
-              context,
+              context as TitleResolutionContext,
             )
           }
           if (newEvent.fields) {

src/languages/lib/render-with-fallback.ts

@@ -1,7 +1,7 @@
 import { renderContent } from '@/content-render/index'
 import Page from '@/frame/lib/page'
 import { TitleFromAutotitleError } from '@/content-render/unified/rewrite-local-links'
-import type { Context } from '@/types'
+import type { Context, Page as PageType } from '@/types'
 
 export class EmptyTitleError extends Error {}
 
@@ -31,8 +31,8 @@ export class LiquidError extends Error {
 interface RenderOptions {
   throwIfEmpty?: boolean
   textOnly?: boolean
-  cache?: boolean | ((template: string, context: any) => string)
-  [key: string]: any
+  cache?: boolean | ((template: string, context: Context) => string)
+  [key: string]: unknown
 }
 
 const LIQUID_ERROR_NAMES = new Set(['RenderError', 'ParseError', 'TokenizationError'])
@@ -117,9 +117,10 @@ export function createTranslationFallbackComment(error: Error, property: string)
 // higher level than `lib/`) how to use the URL to figure out the
 // equivalent English page instance.
 export async function renderContentWithFallback(
-  // Using `any` type for page because the actual Page class from @/frame/lib/page
-  // has more properties than the Page interface defined in @/types, causing type conflicts
-  page: any,
+  // Typed as the @/types Page interface (not the Page class) for caller
+  // compatibility. The runtime contract is stricter: the value must be an
+  // actual Page instance (enforced by the `page instanceof Page` check below).
+  page: PageType,
   property: string,
   context: Context,
   options?: RenderOptions,
@@ -130,7 +131,7 @@ export async function renderContentWithFallback(
   if (typeof property !== 'string') {
     throw new Error(`The second argument has to be a string (not ${typeof property})`)
   }
-  const template = (page as any)[property] as string
+  const template = (page as unknown as Record<string, string>)[property]
   try {
     const output = await renderContent(template, context, options)
     if (options && options.throwIfEmpty && !output.trim()) {
@@ -142,7 +143,7 @@ export async function renderContentWithFallback(
     // on English for.
     if (isFallbackableError(error) && context.getEnglishPage) {
       const enPage = context.getEnglishPage(context)
-      const englishTemplate = (enPage as any)[property] as string
+      const englishTemplate = (enPage as unknown as Record<string, string>)[property]
       // If you don't change the context, it'll confuse the liquid plugins
       // like `data.ts` that uses `environment.scope.currentLanguage`
       const enContext = Object.assign({}, context, { currentLanguage: 'en' })

src/search/lib/routes/combined-search-route.ts

@@ -75,7 +75,14 @@ export async function combinedSearchRoute(req: Request, res: Response) {
       })
     } else {
       generalSearchPromise = Promise.resolve({
-        meta: {} as any,
+        meta: {
+          found: { value: 0, relation: 'eq' },
+          took: { query_msec: 0, total_msec: 0 },
+          // Mirror the requested page size so downstream page-count math
+          // (which divides by meta.size) stays finite for the empty branch.
+          size: GENERAL_RESULTS_SIZE,
+          page: 1,
+        },
         hits: [],
       })
     }

src/search/lib/search-request-params/get-search-from-request-params.ts

@@ -33,7 +33,7 @@ export function getSearchFromRequestParams<Type extends SearchTypes>(
 
   for (const { key, default_, cast, validate, multiple } of searchParamsObject) {
     if (key in forceParams) {
-      ;(searchParams[key] as any) = forceParams[key] as any
+      ;(searchParams[key] as unknown) = forceParams[key]
       continue
     }
 
@@ -69,7 +69,7 @@ export function getSearchFromRequestParams<Type extends SearchTypes>(
       })
     }
 
-    ;(searchParams[key] as any) = value
+    ;(searchParams[key] as unknown) = value
   }
 
   let indexName = ''