Migrate src/shielding console statements to structured logger (#61081)

Author: Ebonsignori

eslint.config.ts

@@ -186,7 +186,6 @@ export default [
       'src/metrics/**/*.{ts,js}',
       'src/observability/lib/handle-package-not-found.ts',
       'src/search/**/*.{ts,js}',
-      'src/shielding/**/*.{ts,js}',
     ],
     rules: {
       'custom-rules/use-custom-logger': 'off',

src/shielding/middleware/handle-invalid-query-string-values.ts

@@ -1,11 +1,14 @@
 import type { Response, NextFunction } from 'express'
 
+import { createLogger } from '@/observability/logger'
 import { ExtendedRequest } from '@/types'
 import statsd from '@/observability/lib/statsd'
 import { allTools } from '@/tools/lib/all-tools'
 import { allPlatforms } from '@/tools/lib/all-platforms'
 import { defaultCacheControl } from '@/frame/middleware/cache-control'
 
+const logger = createLogger(import.meta.url)
+
 const STATSD_KEY = 'middleware.handle_invalid_querystring_values'
 
 // Hi future reader!
@@ -46,11 +49,11 @@ export default function handleInvalidQuerystringValues(
         const values = Array.isArray(queryValue) ? queryValue : [queryValue]
         if (values.some((val) => typeof val === 'string' && !validValues.includes(val))) {
           if (process.env.NODE_ENV === 'development') {
-            console.warn(
-              'Warning! Invalid query string *value* detected. %O is not one of %O',
-              query[key],
+            logger.warn('Invalid query string value detected', {
+              key,
+              value: query[key],
               validValues,
-            )
+            })
           }
           // Some value is not recognized. Redirect to the current URL
           // but with that query string key removed.

src/shielding/middleware/handle-invalid-query-strings.ts

@@ -1,9 +1,12 @@
 import type { Response, NextFunction } from 'express'
 
+import { createLogger } from '@/observability/logger'
 import statsd from '@/observability/lib/statsd'
 import { noCacheControl, defaultCacheControl } from '@/frame/middleware/cache-control'
 import { ExtendedRequest } from '@/types'
 
+const logger = createLogger(import.meta.url)
+
 const STATSD_KEY = 'middleware.handle_invalid_querystrings'
 
 // Exported for the sake of end-to-end tests
@@ -136,7 +139,7 @@ export default function handleInvalidQuerystrings(
 
     if (keys.length >= MAX_UNFAMILIAR_KEYS_REDIRECT || badKeylessQuery || badToolsQuery) {
       if (process.env.NODE_ENV === 'development') {
-        console.warn(
+        logger.warn(
           'Redirecting because of a questionable query string, see https://github.com/github/docs/blob/main/src/shielding/README.md',
         )
       }