Reactivate RAI linter rules (GHD035, GHD064) (#61444)

Author: jc-clark

data/reusables/contributing/content-linter-rules.md

@@ -44,6 +44,7 @@
 | GHD032 | image-alt-text-end-punctuation | Alternate text for images should end with punctuation | error | accessibility, images |
 | GHD033 | incorrect-alt-text-length | Images alternate text should be between 40-150 characters | error | accessibility, images |
 | GHD034 | frontmatter-curly-quotes | Frontmatter title and intro should not contain curly quotes | error | frontmatter, format |
+| GHD035 | rai-reusable-usage | RAI articles and reusables can only reference reusable content in the data/reusables/rai directory | error | feature, rai |
 | GHD036 | image-no-gif | Image must not be a gif, styleguide reference: contributing/style-guide-and-content-model/style-guide.md#images | error | images |
 | GHD038 | expired-content | Expired content must be remediated. | warning | expired |
 | GHD039 | expiring-soon | Content that expires soon should be proactively addressed. | warning | expired |
@@ -64,6 +65,7 @@
 | GHD061 | frontmatter-hero-image | Hero image paths must be absolute, extensionless, and point to valid images in /assets/images/banner-images/ | error | frontmatter, images |
 | GHD062 | frontmatter-intro-links | introLinks keys must be valid keys defined in data/ui.yml under product_landing | error | frontmatter, single-source |
 | GHD063 | frontmatter-children | Children frontmatter paths must exist. Supports relative paths and absolute /content/ paths for cross-product inclusion. | error | frontmatter, children |
+| GHD064 | rai-app-card-structure | RAI application/platform card articles must follow the required template structure | error | feature, rai |
 | GHD065 | frontmatter-content-type | Content files in content-type directories must have a contentType frontmatter property that matches the parent directory. | error | frontmatter, content-type |
 | GHD066 | frontmatter-docs-team-metrics | Articles whose path contains a docsTeamMetrics value must include that value in their docsTeamMetrics frontmatter property. | error | frontmatter, docs-team-metrics |
 | [search-replace](https://github.com/OnkarRuikar/markdownlint-rule-search-replace) | deprecated liquid syntax: octicon-<icon-name> | The octicon liquid syntax used is deprecated. Use this format instead `octicon "<octicon-name>" aria-label="<Octicon aria label>"` | error |  |

src/content-linter/lib/linting-rules/rai-app-card-structure.ts

@@ -331,7 +331,8 @@ interface Frontmatter {
 
 function isFileRaiCard(params: RuleParams): boolean {
   const fm: Frontmatter = (getFrontmatter(params.frontMatterLines) as Frontmatter) || {}
-  return fm.contentType === 'rai'
+  // Files with children: are landing pages that aggregate cards, not cards themselves.
+  return fm.contentType === 'rai' && !('children' in fm)
 }
 
 export const raiAppCardStructure: Rule = {

src/content-linter/style/github-docs.ts

@@ -119,14 +119,11 @@ const githubDocsConfig = {
     'partial-markdown-files': true,
     'yml-files': true,
   },
-  // 'rai-reusable-usage': {
-  //   // GHD035
-  //   // Temporarily disabled until RAI application card PRs merge.
-  //   // Re-enable by uncommenting this block.
-  //   // See: github/docs-internal#59611, #59934, #59936
-  //   severity: 'error',
-  //   'partial-markdown-files': true,
-  // },
+  'rai-reusable-usage': {
+    // GHD035
+    severity: 'error',
+    'partial-markdown-files': true,
+  },
   'image-no-gif': {
     // GHD036
     severity: 'error',
@@ -190,14 +187,11 @@ const githubDocsConfig = {
     'partial-markdown-files': true,
     'yml-files': true,
   },
-  // 'rai-app-card-structure': {
-  //   // GHD064
-  //   // Temporarily disabled until RAI application card PRs merge.
-  //   // Re-enable by uncommenting this block (use 'error' once migration is complete per github/docs-team#6340).
-  //   // See: github/docs-internal#59611, #59934, #59936
-  //   severity: 'warning',
-  //   'partial-markdown-files': false,
-  // },
+  'rai-app-card-structure': {
+    // GHD064
+    severity: 'error',
+    'partial-markdown-files': false,
+  },
 }
 
 export const githubDocsFrontmatterConfig = {