[duplicate-code] Duplicate Code Analysis Report

[github-actions]

Analysis of commit ca03645 (chore: upgrade gh-aw to v0.68.2)

Summary

Analysis of the Go source files changed in the latest push found 2 significant duplication patterns that meet the reporting threshold (>10 lines or 3+ similar instances). Both patterns are in non-test production Go files. The logger Log[Level] boilerplate exists but is considered intentional API exposure and was excluded.

Detected Patterns

1. Repeated shouldAttachAgentTags conditional logging blocks — Severity: Medium — See sub-issue [duplicate-code] Duplicate Code Pattern: Repeated shouldAttachAgentTags Conditional Logging in connection.go #3828
2. getDefault* env-wrapper function proliferation in cmd/flags_* — Severity: Low — See sub-issue [duplicate-code] Duplicate Code Pattern: getDefault* Env-Wrapper Function Proliferation in cmd/flags #3829

Overall Impact

• Total Duplicated Lines: ~40 lines (15 in connection.go, ~25 across flags files)
• Affected Files: 4 files (internal/mcp/connection.go, internal/cmd/flags_logging.go, internal/cmd/flags_difc.go, internal/cmd/flags_tracing.go)
• Maintainability Risk: Medium — the connection.go pattern creates silent divergence risk if the branching logic needs updating; the flags pattern increases file length but is low risk
• Refactoring Priority: Medium for pattern 1; Low for pattern 2

Next Steps

1. Review individual pattern sub-issues for detailed refactoring guidance
2. Pattern 1 (connection.go) is the higher-priority fix — one helper call replaces three duplicate blocks
3. Pattern 2 (flags) can be addressed incrementally as files are touched

Analysis Metadata

• Analyzed Files: ~95 Go source files (excluding *_test.go and test/ directory)
• Detection Method: Semantic + pattern search analysis
• Commit: ca03645
• Analysis Date: 2026-04-15