[safe-output-health] Safe Output Health Report - 2026-04-14 #26222
Closed
Replies: 2 comments 1 reply
-
|
/plan create issue for Fix resolve_pull_request_review_thread Context Check, not the others |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
This discussion has been marked as outdated by Safe Output Health Monitor. A newer discussion is available at Discussion #26434. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Executive Summary
Improvement vs. 2026-04-13: No API rate limit burst today (was 3 hard failures yesterday). Hard failure count dropped from 3 → 1. Trend is improving.
Safe Output Job Statistics
Error Clusters
Cluster 1: PR Context Required for Thread Resolution
resolve_pull_request_review_threadschedule(not a PR event). The safe output handler requires a PR event context to processresolve_pull_request_review_thread, even when an explicitthread_id(PRRT_kwDOPc1QR856zwGl) is provided.Resource not accessible by integration(permissions error). Today the error is a context check — suggesting a context guard was added to the handler, but it's too strict and rejects explicitthread_idcalls.Warnings (Non-Fatal)
Smoke Copilot: submit_pull_request_review — No Review Context
No review context set - cannot submit reviewcreate_pull_request_review_comment(×2) andreply_to_pull_request_review_commentskipped — not in PR event context.Agent Failures Affecting Safe Outputs (Out of Scope, Context Only)
These are not safe output job failures but caused safe output jobs to be skipped entirely:
Bad credentials— PAT for side-repo checkout expired/invalidBad credentials— same PAT issueAPI key not valid— invalid Gemini API keyRoot Cause Analysis
PR Context Restriction in
resolve_pull_request_review_threadThe Smoke Claude workflow runs on a schedule, not on a PR event. The safe output handler for
resolve_pull_request_review_threadchecks for a live PR event context before processing. Even when the agent provides an explicitthread_id, the context guard fires and rejects the call.This behavior is overly strict: if a
thread_idis explicitly provided, the handler could proceed without requiring a PR event context — it has all the information needed to make the API call. The guard is valuable for cases where nothread_idis available (preventing accidental use), but should not block explicitthread_idcalls.No Rate Limit Burst Today
Unlike 2026-04-13 (and 2026-04-02, 2026-04-07), there was no concurrent API rate limit burst at noon UTC today. This is likely because the daily workflow batch was smaller or more spread out.
Recommendations
Critical Issues (Immediate Action)
None today. The single hard failure is a smoke test context issue that does not affect production workflows.
Bug Fixes
resolve_pull_request_review_threadwith explicitthread_idoutside PR event contextsafe_output_handler_manager.cjs(or theresolve_pull_request_review_threadhandler)event_name != 'pull_request', even if an explicitthread_idis in the agent outputthread_idis explicitly provided in the safe output item, bypass the event context check and proceed with the API callProcess Improvements
Renew PAT for
githubnext/gh-aw-side-repo(recurring since 2026-04-07)Bad credentialsValidate Gemini API Key
GEMINI_API_KEYsecret in the repository is valid and not expiredWork Item Plans
Work Item 1: Fix
resolve_pull_request_review_threadContext Checkresolve_pull_request_review_threadsafe output handler rejects calls when the workflow was not triggered by a PR event, even when an explicitthread_idis provided. This causes Smoke Claude's scheduled test to fail.resolve_pull_request_review_threadsucceeds when explicitthread_idis in the payload, regardless of event contextthread_idand no PR event contextthread_idis present in the item payload. If yes, skip the event context guard and proceed. If nothread_id, apply the existing context check.Work Item 2: Renew Cross-Repo PAT Credentials
githubnext/gh-aw-side-repohas expired. Smoke Create Cross-Repo PR and Smoke Update Cross-Repo PR have been failing since 2026-04-07.githubnext/gh-aw-side-repo, update the secret.githubnextorgHistorical Context
Trend Data (Last 7 Audits)
Metrics and KPIs
resolve_pull_request_review_thread(0% — context guard too strict)Next Steps
resolve_pull_request_review_threadto allow explicitthread_idbypass of context checkgithubnext/gh-aw-side-repo(cross-repo smoke tests broken since 2026-04-07)References:
Beta Was this translation helpful? Give feedback.
All reactions