Skip to content

filter installations by GH_ORG#783

Closed
hilmarf wants to merge 2 commits into
github:main-enterprisefrom
hilmarf:fix/installations
Closed

filter installations by GH_ORG#783
hilmarf wants to merge 2 commits into
github:main-enterprisefrom
hilmarf:fix/installations

Conversation

@hilmarf

@hilmarf hilmarf commented Mar 7, 2025

Copy link
Copy Markdown

fixes: #782

@decyjphr

Copy link
Copy Markdown
Collaborator

The env variable GH_ORG is a probot configuration for manifest flow. That is not a required env variable so in most cases. it would not be set.

@hilmarf there might a different way to get the org in question. Let me investigate.

@Simon-Boyer

Simon-Boyer commented May 8, 2025

Copy link
Copy Markdown
Contributor

@decyjphr Could we simply check if that variable (or even another one we define) is there and use it, if not we revert back to using installations[0]?

@hilmarf hilmarf closed this by deleting the head repository Sep 1, 2025
@renan-alm

Copy link
Copy Markdown

Right now this is a limitation.
This feature is needed for managing which orgs are in scope of the settings. Otherwise, we (users) are limited to use a single private GH App per org. In other words, it is a low-handing fruit.

The only work left on this PR is adding tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

don't take fixed: installations[0]

4 participants