Skip to content

Commit 575d6ad

Browse files
test: rename symlink bucketing tests to reflect bucket-and-continue behavior
The two file-bucketing tests at line 300/320 were named *_refuses_*, but the new behavior buckets symlinked file destinations with a warning while safe destinations in the same install still complete. Rename to *_buckets_* and update docstrings to match. The remaining *_refuses_* tests (line 342/362/381) genuinely raise on symlinked dirs/manifests and keep their names.
1 parent a0029bc commit 575d6ad

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

tests/integrations/test_cli.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -297,8 +297,8 @@ def test_shared_infra_warns_when_manifest_cannot_be_decoded(self, tmp_path, caps
297297
assert "A new shared manifest will be created" in captured.out
298298

299299
@pytest.mark.skipif(not hasattr(os, "symlink"), reason="symlinks are unavailable")
300-
def test_shared_infra_refuses_symlinked_script_destination(self, tmp_path, capsys):
301-
"""Shared script refreshes must not follow destination symlinks."""
300+
def test_shared_infra_buckets_symlinked_script_destination(self, tmp_path, capsys):
301+
"""Symlinked script destinations are bucketed with a warning; the symlink target is preserved."""
302302
from specify_cli import _install_shared_infra
303303

304304
project = tmp_path / "symlink-script-test"
@@ -318,8 +318,8 @@ def test_shared_infra_refuses_symlinked_script_destination(self, tmp_path, capsy
318318
assert outside.read_text(encoding="utf-8") == "# outside\n"
319319

320320
@pytest.mark.skipif(not hasattr(os, "symlink"), reason="symlinks are unavailable")
321-
def test_shared_infra_refuses_symlinked_template_destination(self, tmp_path, capsys):
322-
"""Shared template installs must not follow destination symlinks."""
321+
def test_shared_infra_buckets_symlinked_template_destination(self, tmp_path, capsys):
322+
"""Symlinked template destinations are bucketed with a warning; the symlink target is preserved."""
323323
from specify_cli import _install_shared_infra
324324

325325
project = tmp_path / "symlink-template-test"

0 commit comments

Comments
 (0)