fix(workflows): treat falsey non-strings as type errors, not missing fields

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: marcelsafin

src/specify_cli/workflows/_commands.py

@@ -601,11 +601,14 @@ def _validate_and_install_local(yaml_path: Path, source_label: str) -> None:
         except (ValueError, yaml.YAMLError) as exc:
             console.print(f"[red]Error:[/red] Invalid workflow YAML: {exc}")
             raise typer.Exit(1)
-        # Non-string ids (e.g. unquoted ``id: 123``) fall through to
-        # validate_workflow below, which reports a typed error instead of
-        # crashing on ``.strip()`` here.
-        if not definition.id or (
-            isinstance(definition.id, str) and not definition.id.strip()
+        # Non-string ids (e.g. unquoted ``id: 123`` or ``id: 0``) fall through
+        # to validate_workflow below, which reports a typed error instead of
+        # crashing on ``.strip()`` here. Only None/empty/whitespace-only ids
+        # are rejected as missing.
+        if (
+            definition.id is None
+            or definition.id == ""
+            or (isinstance(definition.id, str) and not definition.id.strip())
         ):
             console.print("[red]Error:[/red] Workflow definition has an empty or missing 'id'")
             raise typer.Exit(1)

src/specify_cli/workflows/engine.py

@@ -140,8 +140,10 @@ def validate_workflow(definition: WorkflowDefinition) -> list[str]:
     # -- Top-level fields -------------------------------------------------
     # YAML parses unquoted scalars like ``id: 123`` or ``version: 1.0`` as
     # int/float; check types before regex/string operations so authoring
-    # mistakes surface as validation errors instead of tracebacks.
-    if not definition.id:
+    # mistakes surface as validation errors instead of tracebacks. Only
+    # ``None``/empty-string count as missing so falsey non-strings
+    # (``id: 0``, ``name: false``) still get the typed error.
+    if definition.id is None or definition.id == "":
         errors.append("Workflow is missing 'workflow.id'.")
     elif not isinstance(definition.id, str):
         errors.append(
@@ -154,15 +156,15 @@ def validate_workflow(definition: WorkflowDefinition) -> list[str]:
             f"with hyphens."
         )
 
-    if not definition.name:
+    if definition.name is None or definition.name == "":
         errors.append("Workflow is missing 'workflow.name'.")
     elif not isinstance(definition.name, str):
         errors.append(
             f"'workflow.name' must be a string, got "
             f"{type(definition.name).__name__} ({definition.name!r})."
         )
 
-    if not definition.version:
+    if definition.version is None or definition.version == "":
         errors.append("Workflow is missing 'workflow.version'.")
     elif not isinstance(definition.version, str):
         errors.append(
@@ -277,7 +279,7 @@ def _validate_steps(
             continue
 
         step_id = step_config.get("id")
-        if not step_id:
+        if step_id is None or step_id == "":
             errors.append("Step is missing 'id' field.")
             continue
         if not isinstance(step_id, str):

tests/test_workflows.py

@@ -2687,6 +2687,25 @@ def test_non_string_step_id_reports_error(self):
         errors = validate_workflow(definition)
         assert any("Step ID" in e and "string" in e for e in errors)
 
+    def test_falsey_non_string_scalars_report_typed_errors(self):
+        from specify_cli.workflows.engine import WorkflowDefinition, validate_workflow
+
+        definition = WorkflowDefinition.from_string("""
+workflow:
+  id: 0
+  name: false
+  version: 0.0
+steps:
+  - id: 0
+    command: speckit.specify
+""")
+        errors = validate_workflow(definition)
+        assert any("'workflow.id' must be a string" in e for e in errors)
+        assert any("'workflow.name' must be a string" in e for e in errors)
+        assert any("'workflow.version' must be a string" in e for e in errors)
+        assert any("Step ID must be a string" in e for e in errors)
+        assert not any("missing" in e for e in errors)
+
     def test_unquoted_schema_version_accepted(self):
         from specify_cli.workflows.engine import WorkflowDefinition, validate_workflow