Skip to content

Commit 82fad97

Browse files
codexByron
authored andcommitted
Fix CI platform-specific type checker installation
The test-cygwin fast and perf jobs failed while installing the project test extra. basedpyright pulled nodejs-wheel-binaries, whose Cygwin source build recursively required cmake and ninja and then failed because no make program was available. Exclude Cygwin from the basedpyright requirement because the type check runs only in the Ubuntu Python 3.12 job. Also add the final newline that the lint end-of-file-fixer check required for the generated baseline.
1 parent f6e8762 commit 82fad97

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.basedpyright/baseline.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1125,4 +1125,4 @@
11251125
}
11261126
]
11271127
}
1128-
}
1128+
}

test-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
coverage[toml]
2-
basedpyright==1.39.9 ; python_version >= "3.9"
2+
basedpyright==1.39.9 ; python_version >= "3.9" and sys_platform != "cygwin"
33
ddt >= 1.1.1, != 1.4.3
44
mock ; python_version < "3.8"
55
mypy==1.18.2 ; python_version >= "3.9" # pin mypy version to avoid new errors

0 commit comments

Comments
 (0)