Change docker label format. Should not support bracket chars

[mattmcclean]

Hi,

I am trying to use this sidecar container in an architecture with Amazon EC2 Container Service (ECS). When I try to configure an ECS task definition with the label format connect[8081]=stock-price.service.consul it gives the following error message:

Docker label key connect[8081] contains invalid characters, does not match pattern ^[a-z0-9-.]+$

According to the docker spec the ECS service is correct in checking that the labels contain only lower-cased alphanumeric characters, dots and dashes (see: https://docs.docker.com/engine/userguide/labels-custom-metadata/). It seems however that docker engine is not strict in enforcing this.

Is there any chance this can be changed to support valid Docker tag as per the spec?

[progrium]

Yes, I'm open to proposals.

On Mon, Jan 11, 2016 at 12:35 PM, Matt McClean notifications@github.com
wrote:

Hi,

I am trying to use this sidecar container in an architecture with Amazon
EC2 Container Service (ECS) When I try to configure an ECS task definition
with the label format connect[8081]=stock-priceserviceconsul it gives the
following error message:

Docker label key connect[8081] contains invalid characters, does not match
pattern ^[a-z0-9-]+$

According to the docker spec the ECS service is correct in checking that
the labels contain only lower-cased alphanumeric characters, dots and
dashes (see:
https://docsdockercom/engine/userguide/labels-custom-metadata/) It seems
however that docker engine is not strict in enforcing this

Is there any chance this can be changed to support valid Docker tag as per
the spec?

—
Reply to this email directly or view it on GitHub
#30.

Jeff Lindsay
http://progrium.com

[mattmcclean]

How about having a "dot" separator instead between connect and the port number? An example would be

$ docker run -d --name myservice \
        -l connect.6000=redis.service.consul \
        -l connect.3306=master.mysql.service.consul \
        example/myservice

[progrium]

That's what I was thinking it would have to be. Alright, now if somebody can submit a PR for it. ;)