Fix unexpected CommonDBTM::can() $input param-out type#20
Merged
Conversation
trasher
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a parameter is passed by reference, PHPStan assumes that its type can be changed inside the called method to any type allowed by the signature.
Our
CommonDBTM::can()andCommonDBTM::check()methods have a?array &$input = null. PHPStan therefore consider that the$inputvariable can be changed to either null or an array inside the method. For instance, an error is detected in the following code:But the reality is these methods always preserve the passed type. With the proposed
CommonDBTMCanInputParamOutTypeResolverextension, we will indicate that the type is preserved during the method execution. On the 11.0/bugfixes branch, it fixes 179 errors.