Skip to content

_content/doc: update PATH docs and restructure manage-install.html#351

Open
conooi wants to merge 2 commits into
golang:masterfrom
conooi:fix-docs-installation
Open

_content/doc: update PATH docs and restructure manage-install.html#351
conooi wants to merge 2 commits into
golang:masterfrom
conooi:fix-docs-installation

Conversation

@conooi

@conooi conooi commented Mar 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Update install.html to clarify adding the default Go bin directory
to PATH for Linux and macOS.

Restructure the uninstallation instructions in manage-install.html
to use OS-specific tab panels that match the install page.

Document GOBIN user data cleanup in manage-install.html and remind
users to remove the Go bin directory from their PATH during
uninstallation.

Standardize file paths with proper HTML code tags and lowercase
all occurrences of the word "terminal".

Fixes golang/go#39531

fredsa
fredsa suggested changes Mar 17, 2026
View reviewed changes

@fredsa fredsa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, provided a couple of recommendations.

Comment thread _content/doc/install.html Outdated
Comment thread _content/doc/manage-install.html Outdated
@gopherbot

gopherbot commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

This PR (HEAD: 5a849f1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/website/+/755800.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

gopherbot commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Message from Fred Sauer:

Patch Set 1:

(9 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

@conooi conooi force-pushed the fix-docs-installation branch from 5a849f1 to fce3a48 Compare March 18, 2026 01:05
@gopherbot

gopherbot commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

This PR (HEAD: fce3a48) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/website/+/755800.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

gopherbot commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Message from Fred Sauer:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

@conooi conooi force-pushed the fix-docs-installation branch from fce3a48 to 5ea05fe Compare March 19, 2026 23:10
@gopherbot

gopherbot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

This PR (HEAD: 5ea05fe) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/website/+/755800.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

gopherbot commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Message from Fred Sauer:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

@conooi conooi force-pushed the fix-docs-installation branch from 5ea05fe to 3c4c5cb Compare March 20, 2026 20:31
@gopherbot

gopherbot commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

This PR (HEAD: 3c4c5cb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/website/+/755800.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

gopherbot commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Message from Fred Sauer:

Patch Set 4:

(12 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

@conooi conooi changed the title doc: update macOS PATH instructions for go install tools Update macOS PATH instructions for go install tools Mar 20, 2026
@gopherbot

gopherbot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Message from Connie Ooi:

Patch Set 5:

(12 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Message from Fred Sauer:

Patch Set 5: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Message from Fred Sauer:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

@conooi conooi force-pushed the fix-docs-installation branch from 3c4c5cb to 68e353c Compare March 24, 2026 20:27
@gopherbot

gopherbot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Message from Connie Ooi:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

This PR (HEAD: 68e353c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/website/+/755800.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

gopherbot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Message from Fred Sauer:

Patch Set 6: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

Message from Sean Liao:

Patch Set 6: Hold+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Message from Marc Dougherty:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Message from Fred Sauer:

Patch Set 6:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented May 13, 2026

Copy link
Copy Markdown
Contributor

Message from Fred Sauer:

Patch Set 6:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Message from Sean Liao:

Patch Set 6:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

@conooi conooi changed the title Update macOS PATH instructions for go install tools _content/doc: update PATH instructions for install and uninstall Jun 8, 2026
@conooi conooi changed the title _content/doc: update PATH instructions for install and uninstall _content/doc: update PATH docs and restructure manage-install.html Jun 8, 2026
@conooi conooi force-pushed the fix-docs-installation branch from 68e353c to 079e524 Compare June 8, 2026 19:22
conooi added 2 commits June 8, 2026 12:23
@conooi
doc: update macOS PATH instructions and restructure manage-install.html
565c8d5 
Updates doc/install and doc/manage-install to explicitly mention adding
the GOPATH bin directory to the user's PATH on macOS. Also restructures
the manage-install uninstall layout using tabs panels to match install layouts.

This addresses the suggestion made in:
golang/go#39531 (comment)

Specifically, added a note and example workflow setup instruction for
appending export PATH="$PATH:$(go env GOPATH)/bin" to target shell
profiles. Also broke OS lists details into responsive tabs layouts to fit reviewers feedback criteria.

Change-Id: I00cbc17ba1575689f0fee676f2dd0c6d3ff53dd6
@conooi
_content/doc: address feedback on GOBIN and PATH cleanup
dfbf9e2 
Update manage-install.html to remind users to remove the Go bin directory from their PATH when deleting GOBIN.

Standardize the capitalization of terminal across install.html and manage-install.html.
@conooi conooi force-pushed the fix-docs-installation branch from 079e524 to dfbf9e2 Compare June 8, 2026 19:23
@gopherbot

gopherbot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

This PR (HEAD: dfbf9e2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/website/+/755800.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

gopherbot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Message from Connie Ooi:

Patch Set 6:

(11 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Message from Fred Sauer:

Patch Set 8: Code-Review+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/755800.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fredsa fredsa fredsa requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

x/build/cmd/relui: macOS installer should add GOBIN to PATH

3 participants

@conooi @gopherbot @fredsa