From 3b3b77ef67947bbd1434e8af8795b19eed532343 Mon Sep 17 00:00:00 2001 From: tuanaiseo Date: Thu, 7 May 2026 06:02:39 +0700 Subject: [PATCH] fix(security): dead code in read function - unused return value In sonnet/src/nets/dnc/read.py, the squash_op(weights) call on line 36 has its return value discarded. The function is called for its side effect but the squashed result is never used, meaning the squash_before_access parameter has no effect. Affected files: read.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com> --- sonnet/src/nets/dnc/read.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sonnet/src/nets/dnc/read.py b/sonnet/src/nets/dnc/read.py index 7c1bde61..a05821c7 100644 --- a/sonnet/src/nets/dnc/read.py +++ b/sonnet/src/nets/dnc/read.py @@ -36,7 +36,7 @@ def read(memory, """ with tf.name_scope("read_memory"): if squash_before_access: - squash_op(weights) + weights = squash_op(weights) read_word = tf.matmul(weights, memory) if squash_after_access: read_word = squash_op(read_word)