Skip to content

feat(workflow): NodeInfo.OutputFor for delegation-chain output attrib…#967

Closed
wolo-lab wants to merge 3 commits into
tempfrom
wolo/output-for
Closed

feat(workflow): NodeInfo.OutputFor for delegation-chain output attrib…#967
wolo-lab wants to merge 3 commits into
tempfrom
wolo/output-for

Conversation

@wolo-lab

@wolo-lab wolo-lab commented Jun 5, 2026

Copy link
Copy Markdown

…ution

Add NodeInfo.OutputFor: the node paths an event's Output counts for — the emitter plus any WithUseAsOutput delegating ancestors. A delegating child's single event is stamped OutputFor=[child, parent, ...] and flows up, and the parent no longer re-emits a duplicate terminal output event (full suppression, matching adk-python's _output_delegated + output_for). Resume attributes a descendant's output to its delegating ancestors via OutputFor. Every output event records OutputFor (own path minimum), mirroring adk-python _enrich_event.

Built on the temp integration branch (#960 + #920 + #966); rebase onto v2 once those merge.

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

  • Closes: #issue_number
  • Related: #issue_number

2. Or, if no issue exists, describe the change:

If applicable, please follow the issue templates to provide as much detail as
possible.

Problem:
A clear and concise description of what the problem is.

Solution:
A clear and concise description of what you want to happen and why you choose
this solution.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed go test results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

wolo-lab added 3 commits June 5, 2026 20:02
RunNode gains a per-call WithUseAsOutput() option that promotes a
dynamic child's output to the parent dynamic node's terminal
Event.Output, suppressing the orchestrator body's own return value.
At most one delegating child per parent activation is allowed; a
second attempt returns ErrOutputAlreadyDelegated without invoking
the child.

Builds on the idempotent cache from the previous CL: a WithRunID
replay re-honours the delegation but does not re-run the child.

BUG=515645490
…sOutput

Add NodeInfo.MessageAsOutput: when set and Event.Output is nil, readers
derive the node's output from the event's model text. The static and
dynamic schedulers both honor it (Output wins, message text is the
fallback), mirroring adk-python's _track_event_in_context. Empty text is
a valid output, matching python; AgentNode's own empty-text-skips
behavior is unchanged.

This lets a delegated child whose message IS its output (e.g. an LlmAgent
node) promote its text to the parent via WithUseAsOutput, and feeds it to
a successor on a normal handoff.
…ution

Add NodeInfo.OutputFor: the node paths an event's Output counts for —
the emitter plus any WithUseAsOutput delegating ancestors. A delegating
child's single event is stamped OutputFor=[child, parent, ...] and flows
up, and the parent no longer re-emits a duplicate terminal output event
(full suppression, matching adk-python's _output_delegated + output_for).
Resume attributes a descendant's output to its delegating ancestors via
OutputFor. Every output event records OutputFor (own path minimum),
mirroring adk-python _enrich_event.

Built on the temp integration branch (#960 + #920 + #966); rebase onto v2
once those merge.
@wolo-lab wolo-lab deleted the branch temp June 5, 2026 20:05
@wolo-lab wolo-lab closed this Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant