feat(workflow): NodeInfo.OutputFor for delegation-chain output attrib…#967
Closed
wolo-lab wants to merge 3 commits into
Closed
feat(workflow): NodeInfo.OutputFor for delegation-chain output attrib…#967wolo-lab wants to merge 3 commits into
wolo-lab wants to merge 3 commits into
Conversation
RunNode gains a per-call WithUseAsOutput() option that promotes a dynamic child's output to the parent dynamic node's terminal Event.Output, suppressing the orchestrator body's own return value. At most one delegating child per parent activation is allowed; a second attempt returns ErrOutputAlreadyDelegated without invoking the child. Builds on the idempotent cache from the previous CL: a WithRunID replay re-honours the delegation but does not re-run the child. BUG=515645490
…sOutput Add NodeInfo.MessageAsOutput: when set and Event.Output is nil, readers derive the node's output from the event's model text. The static and dynamic schedulers both honor it (Output wins, message text is the fallback), mirroring adk-python's _track_event_in_context. Empty text is a valid output, matching python; AgentNode's own empty-text-skips behavior is unchanged. This lets a delegated child whose message IS its output (e.g. an LlmAgent node) promote its text to the parent via WithUseAsOutput, and feeds it to a successor on a normal handoff.
…ution Add NodeInfo.OutputFor: the node paths an event's Output counts for — the emitter plus any WithUseAsOutput delegating ancestors. A delegating child's single event is stamped OutputFor=[child, parent, ...] and flows up, and the parent no longer re-emits a duplicate terminal output event (full suppression, matching adk-python's _output_delegated + output_for). Resume attributes a descendant's output to its delegating ancestors via OutputFor. Every output event records OutputFor (own path minimum), mirroring adk-python _enrich_event. Built on the temp integration branch (#960 + #920 + #966); rebase onto v2 once those merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ution
Add NodeInfo.OutputFor: the node paths an event's Output counts for — the emitter plus any WithUseAsOutput delegating ancestors. A delegating child's single event is stamped OutputFor=[child, parent, ...] and flows up, and the parent no longer re-emits a duplicate terminal output event (full suppression, matching adk-python's _output_delegated + output_for). Resume attributes a descendant's output to its delegating ancestors via OutputFor. Every output event records OutputFor (own path minimum), mirroring adk-python _enrich_event.
Built on the temp integration branch (#960 + #920 + #966); rebase onto v2 once those merge.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
A clear and concise description of what the problem is.
Solution:
A clear and concise description of what you want to happen and why you choose
this solution.
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed go test results.
Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.
Checklist
Additional context
Add any other context or screenshots about the feature request here.