Skip to content

Commit 1379cf8

Browse files
authored
fix: standardize storage update marker to string
1 parent 60e2568 commit 1379cf8

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/google/adk/integrations/firestore/firestore_session_service.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -338,9 +338,7 @@ async def get_session(
338338
events=events,
339339
last_update_time=last_update_time,
340340
)
341-
session._storage_update_marker = (
342-
str(current_revision) if current_revision > 0 else None
343-
)
341+
session._storage_update_marker = str(current_revision)
344342
return session
345343

346344
async def list_sessions(

tests/unittests/integrations/firestore/test_firestore_session_service.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ async def test_create_session(mock_firestore_client):
8686
assert session.app_name == app_name
8787
assert session.user_id == user_id
8888
assert session.id
89+
assert session._storage_update_marker == "0"
8990

9091
mock_firestore_client.collection.assert_any_call("adk-session")
9192
mock_firestore_client.collection.assert_any_call("app_states")
@@ -194,6 +195,7 @@ async def test_get_session_found(mock_firestore_client):
194195
assert session.state == {"key": "value"}
195196
assert len(session.events) == 1
196197
assert session.events[0].invocation_id == "test_inv"
198+
assert session._storage_update_marker == "0"
197199

198200

199201
@pytest.mark.asyncio

0 commit comments

Comments
 (0)