From 83488ed8c9c09ccd880f256181959be78ebeed7a Mon Sep 17 00:00:00 2001 From: Michael <7780875+pandego@users.noreply.github.com> Date: Sat, 4 Apr 2026 18:21:58 +0200 Subject: [PATCH] fix(models): register gemma 4 model names --- src/google/adk/models/gemma_llm.py | 2 +- tests/unittests/models/test_models.py | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/src/google/adk/models/gemma_llm.py b/src/google/adk/models/gemma_llm.py index f333bab241..8bbe5924f3 100644 --- a/src/google/adk/models/gemma_llm.py +++ b/src/google/adk/models/gemma_llm.py @@ -205,7 +205,7 @@ def supported_models(cls) -> list[str]: """ return [ - r'gemma-3.*', + r'gemma-.*', ] @cached_property diff --git a/tests/unittests/models/test_models.py b/tests/unittests/models/test_models.py index 16c9567aa8..b793f8a84a 100644 --- a/tests/unittests/models/test_models.py +++ b/tests/unittests/models/test_models.py @@ -14,6 +14,7 @@ from google.adk import models from google.adk.models.anthropic_llm import Claude +from google.adk.models.gemma_llm import Gemma from google.adk.models.google_llm import Gemini from google.adk.models.lite_llm import LiteLlm import pytest @@ -56,6 +57,19 @@ def test_match_claude_family(model_name): assert models.LLMRegistry.resolve(model_name) is Claude +@pytest.mark.parametrize( + 'model_name', + [ + 'gemma-3-27b-it', + 'gemma-4-27b-it', + 'gemma-4-31b-it', + ], +) +def test_match_gemma_family(model_name): + """Test that Gemma models are resolved correctly.""" + assert models.LLMRegistry.resolve(model_name) is Gemma + + @pytest.mark.parametrize( 'model_name', [