diff --git a/base/cvd/.clang-tidy b/base/cvd/.clang-tidy index adb705bacd4..9ee035ae90d 100644 --- a/base/cvd/.clang-tidy +++ b/base/cvd/.clang-tidy @@ -2,6 +2,7 @@ # `parse_headers` bazel feature. Checks: &checks >- + bugprone-argument-comment, clang-analyzer-*, clang-diagnostic-*, -clang-diagnostic-pragma-once-outside-header, diff --git a/base/cvd/cuttlefish/host/commands/cvd/cli/commands/login.cpp b/base/cvd/cuttlefish/host/commands/cvd/cli/commands/login.cpp index 5e4dd22226d..a39b8c13e8a 100644 --- a/base/cvd/cuttlefish/host/commands/cvd/cli/commands/login.cpp +++ b/base/cvd/cuttlefish/host/commands/cvd/cli/commands/login.cpp @@ -76,7 +76,8 @@ class CvdLoginCommand : public CvdCommandHandler { } CurlGlobalInit init; - std::unique_ptr http_client = CurlHttpClient(true); + std::unique_ptr http_client = + CurlHttpClient(/*use_logging_debug_function=*/true); CF_EXPECT(http_client.get(), "Failed to create a http client"); if (!oauth2_request.is_ssh) { diff --git a/base/cvd/cuttlefish/host/commands/cvd/fetch/downloaders.cc b/base/cvd/cuttlefish/host/commands/cvd/fetch/downloaders.cc index 86e4bf2357f..cbad08a25fe 100644 --- a/base/cvd/cuttlefish/host/commands/cvd/fetch/downloaders.cc +++ b/base/cvd/cuttlefish/host/commands/cvd/fetch/downloaders.cc @@ -62,8 +62,7 @@ Result Downloaders::Create(const BuildApiFlags& flags, const std::string& cache_base_path) { std::unique_ptr impl(new Downloaders::Impl()); - const bool use_logging_debug_function = true; - impl->curl_ = CurlHttpClient(use_logging_debug_function); + impl->curl_ = CurlHttpClient(/*use_logging_debug_function=*/true); impl->retrying_http_client_ = RetryingServerErrorHttpClient( *impl->curl_, 10, std::chrono::milliseconds(5000)); diff --git a/base/cvd/cuttlefish/host/commands/metrics/metrics_transmission.cc b/base/cvd/cuttlefish/host/commands/metrics/metrics_transmission.cc index 1234da82eb2..eab8df471fa 100644 --- a/base/cvd/cuttlefish/host/commands/metrics/metrics_transmission.cc +++ b/base/cvd/cuttlefish/host/commands/metrics/metrics_transmission.cc @@ -57,9 +57,8 @@ Result TransmitMetricsEvent( const wireless_android_play_playlog::LogRequest& log_request, ClearcutEnvironment environment) { CurlGlobalInit curl_global_init; - const bool use_logging_debug_function = true; std::unique_ptr http_client = - CurlHttpClient(use_logging_debug_function); + CurlHttpClient(/*use_logging_debug_function=*/true); CF_EXPECT(http_client.get() != nullptr, "Unable to create cURL client for metrics transmission"); CF_EXPECT( diff --git a/base/cvd/cuttlefish/host/libs/metrics/gce_environment.cc b/base/cvd/cuttlefish/host/libs/metrics/gce_environment.cc index 8a28c89d2a9..992729c8cbe 100644 --- a/base/cvd/cuttlefish/host/libs/metrics/gce_environment.cc +++ b/base/cvd/cuttlefish/host/libs/metrics/gce_environment.cc @@ -86,7 +86,8 @@ Result GetZoneValue(std::string_view response_string) { Result> DetectGceEnvironment() { CurlGlobalInit curl_init; - std::unique_ptr http_client = CurlHttpClient(); + std::unique_ptr http_client = + CurlHttpClient(/*use_logging_debug_function=*/true); if (!CF_EXPECT(IsGceEnvironment(*http_client))) { return std::nullopt; }