fix(release): consume process streams safely and handle interrupts in ReleaseNoteGeneration

Author: jinseopkim0

java-cloud-bom/release-note-generation/src/main/java/com/google/cloud/ReleaseNoteGeneration.java

@@ -119,14 +119,28 @@ public static void main(String[] arguments)
   ReleaseNoteGeneration() {}
 
   private static boolean releaseExists(String repository, String tag) {
+    Process process = null;
     try {
       ProcessBuilder builder =
           new ProcessBuilder(
               "gh", "release", "--repo", GOOGLEAPIS_ORG + "/" + repository, "view", tag);
-      Process process = builder.start();
-      return process.waitFor() == 0;
-    } catch (IOException | InterruptedException e) {
+      builder.redirectOutput(ProcessBuilder.Redirect.DISCARD);
+      builder.redirectError(ProcessBuilder.Redirect.DISCARD);
+      process = builder.start();
+      boolean finished = process.waitFor(1, TimeUnit.MINUTES);
+      if (!finished) {
+        return false;
+      }
+      return process.exitValue() == 0;
+    } catch (IOException e) {
+      return false;
+    } catch (InterruptedException e) {
+      Thread.currentThread().interrupt();
       return false;
+    } finally {
+      if (process != null && process.isAlive()) {
+        process.destroyForcibly();
+      }
     }
   }
 
@@ -631,20 +645,43 @@ static String fetchReleaseNote(String owner, String repository, String tag)
       throws IOException, InterruptedException {
     // gh release --repo googleapis/java-storage view v2.16.0
 
-    ProcessBuilder builder =
-        new ProcessBuilder("gh", "release", "--repo", owner + "/" + repository, "view", tag);
-    builder.redirectErrorStream(true);
-    Process process = builder.start();
-    String output =
-        new String(
-            process.getInputStream().readAllBytes(), java.nio.charset.StandardCharsets.UTF_8);
-    boolean finished = process.waitFor(1, TimeUnit.MINUTES);
-    Verify.verify(finished, "The process timed out");
-    if (process.exitValue() != 0) {
-      System.err.println(
-          "Warning: The command failed (release likely not found): " + output.trim());
-      return "";
+    File tempFile = java.nio.file.Files.createTempFile("gh-release-notes", ".txt").toFile();
+    tempFile.deleteOnExit();
+
+    Process process = null;
+    try {
+      ProcessBuilder builder =
+          new ProcessBuilder("gh", "release", "--repo", owner + "/" + repository, "view", tag);
+      builder.redirectErrorStream(true);
+      builder.redirectOutput(ProcessBuilder.Redirect.to(tempFile));
+
+      process = builder.start();
+      boolean finished = process.waitFor(1, TimeUnit.MINUTES);
+      if (!finished) {
+        throw new IOException("The process timed out");
+      }
+
+      String output =
+          new String(
+              java.nio.file.Files.readAllBytes(tempFile.toPath()),
+              java.nio.charset.StandardCharsets.UTF_8);
+
+      if (process.exitValue() != 0) {
+        String trimmedOutput = output.trim();
+        String lowerOutput = trimmedOutput.toLowerCase();
+        if (lowerOutput.contains("not found") || lowerOutput.contains("404")) {
+          System.err.println(
+              "Warning: The command failed (release likely not found): " + trimmedOutput);
+          return "";
+        }
+        throw new IOException("The command failed: " + trimmedOutput);
+      }
+      return output;
+    } finally {
+      if (process != null && process.isAlive()) {
+        process.destroyForcibly();
+      }
+      tempFile.delete();
     }
-    return output;
   }
 }