fix(generator): pass default_universe as keyword argument to get_universe_domain

hebaalazzeh · hebaalazzeh · commit 43e13bd93652 · 2026-07-22T22:34:17.000Z
diff --git a/packages/gapic-generator/gapic/templates/%namespace/%name_%version/%sub/_compat.py.j2 b/packages/gapic-generator/gapic/templates/%namespace/%name_%version/%sub/_compat.py.j2
@@ -69,9 +69,9 @@ except ImportError:
         return api_endpoint
 
     def get_universe_domain(
-        client_universe_domain: Optional[str],
-        universe_domain_env: Optional[str],
-        default_universe: str,
+        client_universe_domain: Optional[str] = None,
+        universe_domain_env: Optional[str] = None,
+        default_universe: str = "googleapis.com",
     ) -> str:
         """Return the universe domain used by the client."""
         universe_domain = default_universe
diff --git a/packages/gapic-generator/gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 b/packages/gapic-generator/gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2
@@ -405,7 +405,7 @@ class {{ service.client_name }}(metaclass={{ service.client_name }}Meta):
         return client_utils.get_universe_domain(
             client_universe_domain,
             universe_domain_env,
-            {{ service.client_name }}._DEFAULT_UNIVERSE,
+            default_universe={{ service.client_name }}._DEFAULT_UNIVERSE,
         )
     
     def _validate_universe_domain(self):

Original file line number	Diff line number	Diff line change
`@@ -405,7 +405,7 @@ class {{ service.client_name }}(metaclass={{ service.client_name }}Meta):`
`405`	`405`	`return client_utils.get_universe_domain(`
`406`	`406`	`client_universe_domain,`
`407`	`407`	`universe_domain_env,`
`408`		`- {{ service.client_name }}._DEFAULT_UNIVERSE,`
	`408`	`+ default_universe={{ service.client_name }}._DEFAULT_UNIVERSE,`
`409`	`409`	`)`
`410`	`410`
`411`	`411`	`def _validate_universe_domain(self):`