From 496b6ef08edf9be4126e30a73a3beeacf1803a3d Mon Sep 17 00:00:00 2001 From: gowerc Date: Tue, 26 Aug 2025 20:20:12 +0100 Subject: [PATCH 1/2] initial --- R/identify.R | 2 +- tests/testthat/test-miscellaneous.R | 34 +++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/R/identify.R b/R/identify.R index bb74dccc..5ebb7f0b 100644 --- a/R/identify.R +++ b/R/identify.R @@ -239,7 +239,7 @@ identify_differences <- function( x = BASE, y = COMP, by = KEYS, - suffix = c(".x", ".y"), + suffixes = c(".x", ".y"), sort = TRUE ) if (nrow(DAT) == 0) { diff --git a/tests/testthat/test-miscellaneous.R b/tests/testthat/test-miscellaneous.R index 9ae054eb..a845675e 100644 --- a/tests/testthat/test-miscellaneous.R +++ b/tests/testthat/test-miscellaneous.R @@ -252,3 +252,37 @@ test_that("datetimes compare as expected", { print(res) ) }) + + +testthat::test_that("#138 - No partial arg matches", { + withr::local_options( + list( + warnPartialMatchArgs = TRUE, + warnPartialMatchDollar = TRUE, + warnPartialMatchAttr = TRUE + ) + ) + + df1 <- data.frame( + index1 = c(0, 0, 1, 1), + index2 = c(1, 2, 1, 2), + value = c(1, 2, 3, 4), + value2 = c(1, 2, 3, 4) + ) + + df2 <- data.frame( + index1 = c(1, 1, 2, 2), + index2 = c(1, 2, 1, 2), + value = c(0, 1, 20, 3), + value2 = c(0, 1, 2, 333) + ) + + expect_no_condition({ + diff_result <- diffdf::diffdf( + df1, + df2, + keys = c("index1", "index2"), + suppress_warnings = TRUE + ) + }) +}) From 5d1bcb67bf10e3a0b1d4dcd809f382ca4455708c Mon Sep 17 00:00:00 2001 From: gowerc Date: Tue, 26 Aug 2025 21:36:09 +0100 Subject: [PATCH 2/2] added missing dependency --- DESCRIPTION | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index 80d9b6b9..8a03ee88 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -29,7 +29,8 @@ Suggests: stringr, devtools, covr, - bit64 + bit64, + withr RoxygenNote: 7.3.2 Roxygen: list(markdown = TRUE) VignetteBuilder: knitr