-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy patherror_pattern_test.go
More file actions
461 lines (408 loc) · 11.4 KB
/
error_pattern_test.go
File metadata and controls
461 lines (408 loc) · 11.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
package pages
import (
"errors"
"fmt"
"net/http"
"net/http/httptest"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
)
type patternError struct {
pattern string
}
func (e *patternError) Error() string {
return "pattern error"
}
func (e *patternError) Pattern() string {
return e.pattern
}
type contextPatternError struct {
pattern string
}
func (e *contextPatternError) Error() string {
return "context pattern error"
}
func (e *contextPatternError) Pattern(*http.Request, int, error) string {
return e.pattern
}
type wrappingError struct {
inner error
}
func (e *wrappingError) Error() string {
return e.inner.Error()
}
func (e *wrappingError) Unwrap() error {
return e.inner
}
func TestErrorPattern_Panics(t *testing.T) {
tests := []struct {
name string
authorizer PageAuthorizer
decoratorStrategy PageDecoratorStrategy
wantPanic bool
panicMessage string
}{
{
name: "nil authorizer panics",
authorizer: nil,
decoratorStrategy: &MockPageDecoratorStrategy{},
wantPanic: true,
panicMessage: "error pattern: authorizer is required",
},
{
name: "nil decoratorStrategy panics",
authorizer: &MockPageAuthorizer{},
decoratorStrategy: nil,
wantPanic: true,
panicMessage: "error pattern: decorator strategy is required",
},
{
name: "valid parameters does not panic",
authorizer: &MockPageAuthorizer{},
decoratorStrategy: &MockPageDecoratorStrategy{},
wantPanic: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if tt.wantPanic {
assert.PanicsWithValue(t, tt.panicMessage, func() {
ErrorPattern(tt.authorizer, tt.decoratorStrategy)
})
} else {
assert.NotPanics(t, func() {
ErrorPattern(tt.authorizer, tt.decoratorStrategy)
})
}
})
}
}
func TestErrorPattern_CustomPattern(t *testing.T) {
authorizer := &MockPageAuthorizer{}
decoratorStrategy := &MockPageDecoratorStrategy{}
tests := []struct {
name string
err error
want string
}{
{
name: "error with Pattern() method",
err: &patternError{pattern: "custom-pattern"},
want: "custom-pattern",
},
{
name: "error with Pattern(*http.Request, int, error) method",
err: &contextPatternError{pattern: "context-pattern"},
want: "context-pattern",
},
{
name: "wrapped error with Pattern() method",
err: &wrappingError{inner: &patternError{pattern: "wrapped-pattern"}},
want: "wrapped-pattern",
},
{
name: "doubly wrapped error with Pattern() method",
err: &wrappingError{inner: &wrappingError{inner: &patternError{pattern: "deeply-wrapped-pattern"}}},
want: "deeply-wrapped-pattern",
},
{
name: "wrapped error with context Pattern() method",
err: &wrappingError{inner: &contextPatternError{pattern: "wrapped-context-pattern"}},
want: "wrapped-context-pattern",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
fn := ErrorPattern(authorizer, decoratorStrategy)
req := httptest.NewRequest(http.MethodGet, "/test", nil)
got := fn(req, http.StatusInternalServerError, tt.err)
assert.Equal(t, tt.want, got)
})
}
}
func TestErrorPattern_ErrPageNotFound(t *testing.T) {
tests := []struct {
name string
authDecision Decision
decorable bool
want string
}{
{
name: "ErrPageNotFound with Allow and decorable returns PageInternalCreate",
authDecision: Allow,
decorable: true,
want: PageInternalCreate,
},
{
name: "ErrPageNotFound with Deny and decorable returns PageErrorNotFound",
authDecision: Deny,
decorable: true,
want: PageErrorNotFound,
},
{
name: "ErrPageNotFound with Allow and not decorable returns PageErrorNotFound",
authDecision: Allow,
decorable: false,
want: PageErrorNotFound,
},
{
name: "ErrPageNotFound with Deny and not decorable returns PageErrorNotFound",
authDecision: Deny,
decorable: false,
want: PageErrorNotFound,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
authorizer := &MockPageAuthorizer{}
authorizer.On("Authorize", mock.Anything, CreatePage).Return(tt.authDecision)
decoratorStrategy := &MockPageDecoratorStrategy{}
decoratorStrategy.On("IsURIDecorable", mock.Anything, "/test").Return(tt.decorable)
fn := ErrorPattern(authorizer, decoratorStrategy)
req := httptest.NewRequest(http.MethodGet, "/test", nil)
got := fn(req, http.StatusNotFound, ErrPageNotFound)
assert.Equal(t, tt.want, got)
decoratorStrategy.AssertCalled(t, "IsURIDecorable", mock.Anything, "/test")
if tt.decorable {
authorizer.AssertCalled(t, "Authorize", mock.Anything, CreatePage)
} else {
authorizer.AssertNotCalled(t, "Authorize")
}
})
}
}
func TestErrorPattern_StatusCodes(t *testing.T) {
authorizer := &MockPageAuthorizer{}
authorizer.On("Authorize", mock.Anything, CreatePage).Return(Deny)
decoratorStrategy := &MockPageDecoratorStrategy{}
decoratorStrategy.On("IsURIDecorable", mock.Anything, mock.Anything).Return(false)
fn := ErrorPattern(authorizer, decoratorStrategy)
req := httptest.NewRequest(http.MethodGet, "/test", nil)
err := errors.New("some error")
tests := []struct {
name string
status int
want string
}{
{
name: "401 returns PageErrorUnauthorized",
status: http.StatusUnauthorized,
want: PageErrorUnauthorized,
},
{
name: "403 returns PageErrorForbidden",
status: http.StatusForbidden,
want: PageErrorForbidden,
},
{
name: "404 returns PageErrorNotFound",
status: http.StatusNotFound,
want: PageErrorNotFound,
},
{
name: "400 returns PageError4xx",
status: http.StatusBadRequest,
want: PageError4xx,
},
{
name: "402 returns PageError4xx",
status: 402,
want: PageError4xx,
},
{
name: "499 returns PageError4xx",
status: 499,
want: PageError4xx,
},
{
name: "500 returns PageError5xx",
status: http.StatusInternalServerError,
want: PageError5xx,
},
{
name: "502 returns PageError5xx",
status: http.StatusBadGateway,
want: PageError5xx,
},
{
name: "599 returns PageError5xx",
status: 599,
want: PageError5xx,
},
{
name: "200 returns PageError5xx (2xx falls to 5xx)",
status: http.StatusOK,
want: PageError5xx,
},
{
name: "300 returns PageError5xx (3xx falls to 5xx)",
status: http.StatusMultipleChoices,
want: PageError5xx,
},
{
name: "600 returns PageError5xx (out of range falls to 5xx)",
status: 600,
want: PageError5xx,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got := fn(req, tt.status, err)
assert.Equal(t, tt.want, got)
})
}
}
func TestErrorPattern_Priority(t *testing.T) {
authorizer := &MockPageAuthorizer{}
authorizer.On("Authorize", mock.Anything, CreatePage).Return(Allow)
decoratorStrategy := &MockPageDecoratorStrategy{}
decoratorStrategy.On("IsURIDecorable", mock.Anything, mock.Anything).Return(true)
fn := ErrorPattern(authorizer, decoratorStrategy)
req := httptest.NewRequest(http.MethodGet, "/test", nil)
tests := []struct {
name string
status int
err error
want string
}{
{
name: "custom pattern takes priority over ErrPageNotFound",
status: http.StatusNotFound,
err: &patternError{pattern: "custom"},
want: "custom",
},
{
name: "custom pattern takes priority over status 401",
status: http.StatusUnauthorized,
err: &contextPatternError{pattern: "custom-401"},
want: "custom-401",
},
{
name: "ErrPageNotFound with Allow returns PageInternalCreate",
status: http.StatusNotFound,
err: ErrPageNotFound,
want: PageInternalCreate,
},
{
name: "status 401 returns PageErrorUnauthorized when no custom pattern",
status: http.StatusUnauthorized,
err: errors.New("other error"),
want: PageErrorUnauthorized,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got := fn(req, tt.status, tt.err)
assert.Equal(t, tt.want, got)
})
}
}
func TestErrorPattern_WrappingUnwrapping(t *testing.T) {
authorizer := &MockPageAuthorizer{}
decoratorStrategy := &MockPageDecoratorStrategy{}
decoratorStrategy.On("IsURIDecorable", mock.Anything, mock.Anything).Return(false)
fn := ErrorPattern(authorizer, decoratorStrategy)
req := httptest.NewRequest(http.MethodGet, "/test", nil)
tests := []struct {
name string
err error
want string
}{
{
name: "pattern error wrapped in standard errors",
err: fmt.Errorf("wrapped: %w", &patternError{pattern: "inner-pattern"}),
want: "inner-pattern",
},
{
name: "multiple levels of wrapping",
err: &wrappingError{inner: &wrappingError{inner: &patternError{pattern: "deep-pattern"}}},
want: "deep-pattern",
},
{
name: "mixed wrapping with errors.Wrap and custom wrapper",
err: &wrappingError{inner: fmt.Errorf("standard: %w", &patternError{pattern: "mixed-pattern"})},
want: "mixed-pattern",
},
{
name: "wrapped ErrPageNotFound",
err: fmt.Errorf("wrapped: %w", ErrPageNotFound),
want: PageErrorNotFound,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got := fn(req, http.StatusNotFound, tt.err)
assert.Equal(t, tt.want, got)
})
}
}
func TestErrorPattern_EmptyRequest(t *testing.T) {
authorizer := &MockPageAuthorizer{}
authorizer.On("Authorize", mock.Anything, CreatePage).Return(Deny)
decoratorStrategy := &MockPageDecoratorStrategy{}
decoratorStrategy.On("IsURIDecorable", mock.Anything, mock.Anything).Return(false)
fn := ErrorPattern(authorizer, decoratorStrategy)
tests := []struct {
name string
req *http.Request
status int
err error
want string
}{
{
name: "nil request",
req: nil,
status: http.StatusNotFound,
err: errors.New("test"),
want: PageErrorNotFound,
},
{
name: "empty request",
req: &http.Request{},
status: http.StatusNotFound,
err: errors.New("test"),
want: PageErrorNotFound,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got := fn(tt.req, tt.status, tt.err)
assert.Equal(t, tt.want, got)
})
}
}
func BenchmarkErrorPattern_CustomPattern(b *testing.B) {
authorizer := &MockPageAuthorizer{}
decoratorStrategy := &MockPageDecoratorStrategy{}
fn := ErrorPattern(authorizer, decoratorStrategy)
req := httptest.NewRequest(http.MethodGet, "/test", nil)
err := &patternError{pattern: "custom"}
b.ResetTimer()
for i := 0; i < b.N; i++ {
fn(req, http.StatusInternalServerError, err)
}
}
func BenchmarkErrorPattern_ErrPageNotFound(b *testing.B) {
authorizer := &MockPageAuthorizer{}
authorizer.On("Authorize", mock.Anything, CreatePage).Return(Allow)
decoratorStrategy := &MockPageDecoratorStrategy{}
decoratorStrategy.On("IsURIDecorable", mock.Anything, "/test").Return(true)
fn := ErrorPattern(authorizer, decoratorStrategy)
req := httptest.NewRequest(http.MethodGet, "/test", nil)
b.ResetTimer()
for i := 0; i < b.N; i++ {
fn(req, http.StatusNotFound, ErrPageNotFound)
}
}
func BenchmarkErrorPattern_StatusCodes(b *testing.B) {
authorizer := &MockPageAuthorizer{}
decoratorStrategy := &MockPageDecoratorStrategy{}
fn := ErrorPattern(authorizer, decoratorStrategy)
req := httptest.NewRequest(http.MethodGet, "/test", nil)
err := errors.New("test")
b.ResetTimer()
for i := 0; i < b.N; i++ {
fn(req, http.StatusInternalServerError, err)
}
}