Commit 080d2e4
committed
fix(npf): port DS halo-under-rim cross-fade AA to kill the sphere seam ring
The node-graph glow-halo pass started exactly at the sphere edge (discard
r<1.0) while the body's antialiased rim feathers to alpha 0 by r=1 — leaving
the ~1px feather band lit by neither, so the dark page showed through as a
1-2px seam ring around every sphere (glaring when the halo flared red). This
is the antialiasing defect vs the GRCE Design System canvas.
Surgical port of the DS fix: only the SPHERE_FS halo pass changes — it now
ramps the halo up from inner = 1 - 2*vFeather (the body feather start), so
body-fade and halo-rise are exact complements and cross-fade into continuous
light. Expressed in this page's own vFeather varying so the complement is
exact against its crisper ~1.2px body feather, preserving the page's superior
frustum-fill/AA tuning (FILL 1.08, rim-bias, 280 cap, DPR budget) untouched.
Mirror (grce-design-system) already carried the canvas fix (commit 8d08367).1 parent 226bcad commit 080d2e4
2 files changed
Lines changed: 37 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
29 | 50 | | |
30 | 51 | | |
31 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
190 | | - | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
191 | 199 | | |
192 | | - | |
193 | | - | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
194 | 207 | | |
195 | 208 | | |
196 | 209 | | |
| |||
0 commit comments