From 6adf099395f07a614ae545b8122005b661a3f2da Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 1 Nov 2022 11:34:36 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- .../process_schemas.py | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/resources/CodeGenerationFromGA4GH/process_schemas.py b/resources/CodeGenerationFromGA4GH/process_schemas.py index 97764fa..e3cb24c 100644 --- a/resources/CodeGenerationFromGA4GH/process_schemas.py +++ b/resources/CodeGenerationFromGA4GH/process_schemas.py @@ -405,7 +405,26 @@ def getSchemaFromGitHub(self): self.version) self.download(url, self.sourceTar) with tarfile.open(self.sourceTar, "r") as tarball: - tarball.extractall(self.tmpDir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tarball, self.tmpDir) def getSchemaFromLocal(self): """