Wrong date calculation

[Lm0490]

Using this script in scriptable I get (today) shown that it will be 384 days until Christmas ... that doesn’t seem to be quite right - so any idea why that might be?

[thirstbuster]

Hello I'm new to this I liked the Christmas widget I was trying to edit🎬 it to have it include New Years after Christmas was over but I ran in to an error can you help

class ChristmasWidget
{
run()
{
let today = new Date(Date.now());
let Christmas = new Date(Date.now());
let NewYear = new Date(Date.now());
Christmas.setMonth(11);
Christmas.setDate(24);
NewYear.setMonth(11);
NewYear.setDate(31);

    if (today.getMonth() > Christmas.getMonth())
    {
      if(today.getDay() > Christmas.getDay()) 
      {
        let widget = this.deployWidget2();
        if (!config.runsInWidget) 
        {
          widget.presentSmall();
          Script.setWidget(widget);
          Script.complete();
        } else
        {
          let widget = this.deployWidget();
          if (!config.runsInWidget)
          {
            widget.presentSmall();
            Script.setWidget(widget);
            Script.complete();
          }
        }
      
      } else
      {
        let widget = this.deployWidget();
        if (!config.runsInWidget)
        {
          widget.presentSmall();
          Script.setWidget(widget);
          Script.complete();
        }
      }
    }
   

}

deployWidget2()
{
    let list = new ListWidget();
    list.setPadding(12, 12, 12, 12);

    let titleTxt = list.addText("💥🧨 COUNTDOWN\nUNTIL New Years");
    titleTxt.font = Font.mediumSystemFont(13);

    list.addText("");

    let daysLeft = this.calculateDaysLeft();
    let daysLeftTxt = list.addText(daysLeft + " Days");
    daysLeftTxt.textColor = this.decideDisplayColor(daysLeft);
    daysLeftTxt.font = Font.boldSystemFont(24);

    list.addText("");

    let treeBottomLine = list.addText("🧨💥🧨💥");
    treeBottomLine.font = Font.boldSystemFont(24);

    return list
}

deployWidget()
{
    let list = new ListWidget();
    list.setPadding(12, 12, 12, 12);

    let titleTxt = list.addText("🎅 COUNTDOWN\nUNTIL CHRISTMAS");
    titleTxt.font = Font.mediumSystemFont(13);

    list.addText("");

    let daysLeft = this.calculateDaysLeft();
    let daysLeftTxt = list.addText(daysLeft + " Days");
    daysLeftTxt.textColor = this.decideDisplayColor(daysLeft);
    daysLeftTxt.font = Font.boldSystemFont(24);

    list.addText("");

    let treeBottomLine = list.addText("🎄🎄🎄🎄");
    treeBottomLine.font = Font.boldSystemFont(24);

    return list
}

calculateDaysLeft()
{
    let today = new Date(Date.now());
    let christmas = new Date(Date.now());
    christmas.setMonth(11);
    christmas.setDate(24);

    // check if we need to use christmas next year
    if (
        today.getMonth() > christmas.getMonth()
        || (today.getMonth() === christmas.getMonth() && today.getDay() > christmas.getDay())
    ) {
        let nextYear = christmas.getFullYear();
        nextYear = nextYear + 0;
        christmas.setFullYear(nextYear);
    }

    christmas = christmas.getTime();
    today = today.getTime();

    let convertInDays = 24*3600*1000;
    return parseInt((christmas - today)/convertInDays);
}

decideDisplayColor(daysLeft)
{
    if (daysLeft >= 50) {
        return Color.red();
    }

    if (daysLeft >= 30) {
        return Color.yellow();
    }

    return Color.green();
}

}

new ChristmasWidget().run();

Thank you.

[twentythreeme]

Just change

if (today.getMonth() > targetDate.getMonth()
	|| (today.getMonth() === targetDate.getMonth() && today.getDay() > targetDate.getDay())
) 

to

if (today.getMonth() > targetDate.getMonth()
	|| (today.getMonth() === targetDate.getMonth() && today.getDay() > targetDate.getDay())
) 

.getDay() returns the weekday, while .getDate() returns the Date of the Month!

[thirstbuster]

It worked thank you!