-
-
Notifications
You must be signed in to change notification settings - Fork 243
Open
Description
Enabling notifications and mentioning oneself will still notify, for example, typing @myUsername in chat would play the notification name, and also the alert; this should not happen.
I am assuming changing
if (
typeof (myNick) === 'string' && (
args.text.match(new RegExp('@' + myNick.split('#')[0] + '\\b', "gi")) ||
((args.type === "whisper" || args.type === "invite") && args.from)
)
) {
notify(args);
}to
if (
typeof (myNick) === 'string' && (
args.text.match(new RegExp('@' + myNick.split('#')[0] + '\\b', "gi")) ||
((args.type === "whisper" || args.type === "invite") && args.from && args.from != myNick)
)
) {
notify(args);
}at function pushMessage in client.js might fix this issue, but I cannot test; see next issue below:
Another issue: trying to connect to a channel after running npm start on the cloned repo will not allow websocket connects; it just gets stuck on "can't connect; retrying" and loops it forever, so you can't even check if your code is correct.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels